From: Junio C Hamano <gitster@pobox.com>
To: Dave Borowitz <dborowitz@google.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 8/9] Support signing pushes iff the server supports it
Date: Wed, 19 Aug 2015 12:58:36 -0700 [thread overview]
Message-ID: <xmqqpp2j82z7.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1439998007-28719-9-git-send-email-dborowitz@google.com> (Dave Borowitz's message of "Wed, 19 Aug 2015 11:26:46 -0400")
Dave Borowitz <dborowitz@google.com> writes:
> Add a new flag --signed-if-possible to push and send-pack that sends a
> push certificate if and only if the server advertised a push cert
> nonce. If not, at least warn the user that their push may not be as
> secure as they thought.
>
> Signed-off-by: Dave Borowitz <dborowitz@google.com>
> ---
Obviously, the above description needs updating. Here is what I've
queued tentatively.
Thanks.
commit 32d273dfabb0a70b2839971f5afff7fa86a8f4c2
Author: Dave Borowitz <dborowitz@google.com>
Date: Wed Aug 19 11:26:46 2015 -0400
push: support signing pushes iff the server supports it
Add a new flag --sign=true (or --sign=false), which means the same
thing as the original --signed (or --no-signed). Give it a third
value --sign=if-asked to tell push and send-pack to send a push
certificate if and only if the server advertised a push cert nonce.
If not, warn the user that their push may not be as secure as they
thought.
Signed-off-by: Dave Borowitz <dborowitz@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
next prev parent reply other threads:[~2015-08-19 19:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-19 15:26 [PATCH v2 0/9] Flags and config to sign pushes by default Dave Borowitz
2015-08-19 15:26 ` [PATCH v2 1/9] Documentation/git-push.txt: Document when --signed may fail Dave Borowitz
2015-08-19 15:26 ` [PATCH v2 2/9] Documentation/git-send-pack.txt: Flow long synopsis line Dave Borowitz
2015-08-19 19:56 ` Junio C Hamano
2015-08-19 19:59 ` Dave Borowitz
2015-08-19 20:10 ` Junio C Hamano
2015-09-11 16:22 ` Junio C Hamano
2015-08-19 15:26 ` [PATCH v2 3/9] Documentation/git-send-pack.txt: Document --signed Dave Borowitz
2015-08-19 15:26 ` [PATCH v2 4/9] gitremote-helpers.txt: Document pushcert option Dave Borowitz
2015-08-19 15:26 ` [PATCH v2 5/9] transport: Remove git_transport_options.push_cert Dave Borowitz
2015-08-19 15:26 ` [PATCH v2 6/9] config.c: Expose git_parse_maybe_bool Dave Borowitz
2015-08-19 15:26 ` [PATCH v2 7/9] builtin/send-pack.c: Use option parsing API Dave Borowitz
2015-08-19 18:00 ` Stefan Beller
2015-08-19 19:46 ` Dave Borowitz
2015-08-21 15:06 ` Jeff King
2015-08-19 15:26 ` [PATCH v2 8/9] Support signing pushes iff the server supports it Dave Borowitz
2015-08-19 19:58 ` Junio C Hamano [this message]
2015-08-19 20:00 ` Dave Borowitz
2015-08-19 15:26 ` [PATCH v2 9/9] Add a config option push.gpgSign for default signed pushes Dave Borowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpp2j82z7.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=dborowitz@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).