From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Lars Schneider <larsxschneider@gmail.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] usage: add NORETURN to BUG() function definitions
Date: Tue, 23 May 2017 12:32:56 +0900 [thread overview]
Message-ID: <xmqqpof0memv.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <15d73455-6d0e-e67a-7cf3-eb0ae9aa3b0d@ramsayjones.plus.com> (Ramsay Jones's message of "Mon, 22 May 2017 15:02:16 +0100")
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> Having said that, I rarely run sparse over just one file (except
> when fixing a sparse error/warning). On each branch (master->next->pu)
> I do
>
> $ make sparse >sp-out 2>&1 # nsp-out on 'next', psp-out on 'pu'
>
> ... so that I can diff the files from branch to branch. (I check the
> master branch file by hand. There is a single warning on Linux that
> is actually a sparse problem).
>
> Just FYI, for today's fetch:
>
> $ diff sp-out nsp-out
> $ diff nsp-out psp-out
> 12a13
> > SP blame.c
> 42a44,46
> > diff.c:813:6: warning: symbol 'emit_line' was not declared. Should it be static?
> > diff.c:828:6: warning: symbol 'emit_line_fmt' was not declared. Should it be static?
> > diff.c:1865:6: warning: symbol 'print_stat_summary_0' was not declared. Should it be static?
> 54a59
> > SP fsmonitor.c
> 137a143
> > SP sub-process.c
> 170a177
> > SP compat/fopen.c
> 276a284
> > builtin/worktree.c:539:38: warning: Using plain integer as NULL pointer
> 296a305
> > SP t/helper/test-dir-iterator.c
> $
Interesting. One thing that I found somewhat suboptimal is that we
do not get signalled by non-zero exit. Otherwise it would make a
good addition to the "Static Analysis" task in .travis.yml file.
next prev parent reply other threads:[~2017-05-23 3:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-21 22:25 [PATCH] usage: add NORETURN to BUG() function definitions Ramsay Jones
2017-05-22 1:43 ` Junio C Hamano
2017-05-22 2:13 ` Ramsay Jones
2017-05-22 2:35 ` Junio C Hamano
2017-05-22 2:46 ` Junio C Hamano
2017-05-22 14:02 ` Ramsay Jones
2017-05-23 3:32 ` Junio C Hamano [this message]
2017-05-23 20:47 ` Ramsay Jones
2017-05-22 11:19 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpof0memv.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).