From: Junio C Hamano <gitster@pobox.com>
To: Alex Vandiver <alexmv@dropbox.com>
Cc: git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Ben Peart <peartben@gmail.com>
Subject: Re: [PATCH 5/6] fsmonitor: Remove debugging lines from t/t7519-status-fsmonitor.sh
Date: Tue, 19 Dec 2017 12:19:53 -0800 [thread overview]
Message-ID: <xmqqpo7av5au.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <0e1b58795c3cfe2a6a64ae8ab0f87f46e5716da4.1513642743.git.alexmv@dropbox.com> (Alex Vandiver's message of "Mon, 18 Dec 2017 16:28:57 -0800")
Alex Vandiver <alexmv@dropbox.com> writes:
> These were mistakenly left in when the test was introduced, in
> 1487372d3 ("fsmonitor: store fsmonitor bitmap before splitting index",
> 2017-11-09)
>
> Signed-off-by: Alex Vandiver <alexmv@dropbox.com>
> ---
> t/t7519-status-fsmonitor.sh | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/t/t7519-status-fsmonitor.sh b/t/t7519-status-fsmonitor.sh
> index eb2d13bbc..19b2a0a0f 100755
> --- a/t/t7519-status-fsmonitor.sh
> +++ b/t/t7519-status-fsmonitor.sh
> @@ -307,9 +307,7 @@ test_expect_success 'splitting the index results in the same state' '
> dirty_repo &&
> git update-index --fsmonitor &&
> git ls-files -f >expect &&
> - test-dump-fsmonitor >&2 && echo &&
> git update-index --fsmonitor --split-index &&
> - test-dump-fsmonitor >&2 && echo &&
> git ls-files -f >actual &&
> test_cmp expect actual
> '
Hmph, by default the standard output and standard error streams are
not shown in the test output, and it would help while debugging test
failures, so I am not sure if this is a good change. With the
previous step [4/6], we can lose the "echo", of course, and I do not
think we need >&2 redirection there, either.
next prev parent reply other threads:[~2017-12-19 20:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-19 0:28 [PATCH 0/6] Minor fsmonitor bugfixes, use with `git diff` Alex Vandiver
2017-12-19 0:28 ` [PATCH 1/6] Fix comments to agree with argument name Alex Vandiver
2017-12-19 0:28 ` [PATCH 2/6] fsmonitor: Add dir.h include, for untracked_cache_invalidate_path Alex Vandiver
2017-12-19 20:17 ` Junio C Hamano
2017-12-20 20:59 ` Alex Vandiver
2017-12-21 21:47 ` Junio C Hamano
2017-12-19 0:28 ` [PATCH 3/6] fsmonitor: Update helper tool, now that flags are filled later Alex Vandiver
2017-12-20 21:12 ` Alex Vandiver
2017-12-19 0:28 ` [PATCH 4/6] fsmonitor: Add a trailing newline to test-dump-fsmonitor Alex Vandiver
2017-12-19 20:28 ` Junio C Hamano
2017-12-21 1:55 ` Alex Vandiver
2017-12-21 21:49 ` Junio C Hamano
2017-12-19 0:28 ` [PATCH 5/6] fsmonitor: Remove debugging lines from t/t7519-status-fsmonitor.sh Alex Vandiver
2017-12-19 20:19 ` Junio C Hamano [this message]
2017-12-20 17:35 ` Johannes Schindelin
2017-12-19 0:28 ` [PATCH 6/6] fsmonitor: Use fsmonitor data in `git diff` Alex Vandiver
-- strict thread matches above, loose matches on Subject: below --
2018-01-03 3:04 [PATCH v2 0/6] Minor fsmonitor bugfixes, use with " Alex Vandiver
2018-01-03 3:04 ` [PATCH 1/6] Fix comments to agree with argument name Alex Vandiver
2018-01-03 3:04 ` [PATCH 5/6] fsmonitor: Remove debugging lines from t/t7519-status-fsmonitor.sh Alex Vandiver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpo7av5au.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=alexmv@dropbox.com \
--cc=git@vger.kernel.org \
--cc=peartben@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).