list mirror (unofficial, one of many)
 help / color / Atom feed
From: Junio C Hamano <>
To: "Robert P. J. Day" <>
Cc: Git Mailing list <>
Subject: Re: [PATCH v2] Correct mispellings of ".gitmodule" to ".gitmodules"
Date: Wed, 14 Feb 2018 11:37:03 -0800
Message-ID: <> (raw)
In-Reply-To: <alpine.LFD.2.21.1802131907480.17291@localhost.localdomain>

"Robert P. J. Day" <> writes:

> There are a small number of misspellings, ".gitmodule", scattered
> throughout the code base, correct them ... no apparent functional
> changes.
>  Documentation/technical/api-submodule-config.txt | 2 +-
>  contrib/subtree/git-subtree.txt                  | 2 +-
>  submodule-config.c                               | 4 ++--
>  t/                      | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> Signed-off-by: Robert P. J. Day <>
> ---
>   can't believe i forgot to sign my own patch. le *sigh* ...
> diff --git a/Documentation/technical/api-submodule-config.txt b/Documentation/technical/api-submodule-config.txt

Just for future reference, the diffstat and summary comes _after_
the three-dash line, before which is your sign-off, and after which
you can have additional comment like "can't believe...".

No need to resend, as I can remove the cruft from the log message
while queuing.

Thanks.  The patch looks good.  Will queue.

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14  0:09 Robert P. J. Day
2018-02-14 19:37 ` Junio C Hamano [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:

AGPL code for this site: git clone public-inbox