From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Hans Jerry Illikainen <hji@dyntopia.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/1] commit: make the sign-off trailer configurable
Date: Mon, 06 Jan 2020 12:31:28 -0800 [thread overview]
Message-ID: <xmqqpnfw8gyn.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <cfa40ca5-98a1-fc9c-9ccc-f14b81119e60@gmail.com> (Derrick Stolee's message of "Mon, 6 Jan 2020 14:53:58 -0500")
Derrick Stolee <stolee@gmail.com> writes:
> Since I started the line of "this isn't a bad idea" I'll follow up with
> the historical search. Here are previous attempts from 2018 [1], 2015 [2],
> 2010 [3].
>
> Thanks,
> -Stolee
>
> [1] https://lore.kernel.org/git/20180204020318.4363-1-chenjingpiao@gmail.com/
> [2] https://lore.kernel.org/git/1435217454-5718-1-git-send-email-cmarcelo@gmail.com/
> [3] https://lore.kernel.org/git/alpine.LNX.2.00.1001131635510.16395@vqena.qenxr.bet.am/
Thanks. In an earlier thread, we did
https://lore.kernel.org/git/20090401175153.GA90421@macbook.lan/
to which I said "... the wording we can update if somebody can come
up with a better one" in its follow-up. Perhaps it's time for us to
be that somebody to help everybody to be on the same page.
Here is my attempt, starting from what I wrote in
https://lore.kernel.org/git/xmqqtw9m5s5m.fsf@gitster.mtv.corp.google.com/
-- >8 --
Subject: commit -s: document why commit.signoff option will not be added
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
As I said in https://lore.kernel.org/git/7veiw69p26.fsf@gitster.siamese.dyndns.org/
I have a mixed feeling about this. To projects that use the same
definition of what SoB means, not adding the configuration ever is
the right thing to do, but Git is to be used by other projects, and
some of them may use SoB with a completely different meaning that
has no legal weight---and to them, lack of such an automation may
be a bug. So ...
Documentation/git-commit.txt | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt
index ced5a9beab..1909551087 100644
--- a/Documentation/git-commit.txt
+++ b/Documentation/git-commit.txt
@@ -171,6 +171,13 @@ The `-m` option is mutually exclusive with `-c`, `-C`, and `-F`.
the rights to submit this work under the same license and
agrees to a Developer Certificate of Origin
(see http://developercertificate.org/ for more information).
++
+As it makes it harder to argue against one who tells the court "that
+log message ends with a SoB by person X but it is very plausible
+that it was done by inertia without person X really intending to
+certify what DCO says, and the SoB is meaningless." to more
+publicized ways to add SoB automatically, Git does not (and will not)
+have a configuration variable to enable it by default.
-n::
--no-verify::
next prev parent reply other threads:[~2020-01-06 20:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-05 17:41 [PATCH 0/1] commit: make the sign-off trailer configurable Hans Jerry Illikainen
2020-01-05 17:41 ` [PATCH 1/1] " Hans Jerry Illikainen
2020-01-06 13:38 ` Derrick Stolee
2020-01-06 16:53 ` Junio C Hamano
2020-01-06 19:53 ` Derrick Stolee
2020-01-06 20:31 ` Junio C Hamano [this message]
2020-01-06 20:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpnfw8gyn.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=hji@dyntopia.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).