From: Junio C Hamano <gitster@pobox.com>
To: "Liam Huang via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/1] Update imap-send.c, fix incompatibilities with OpenSSL 1.1.x
Date: Tue, 07 Jan 2020 12:19:15 -0800 [thread overview]
Message-ID: <xmqqpnfv3tq4.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <8c96c56a1818b066d4570873e00c52d42399e3c2.1578391376.git.gitgitgadget@gmail.com> (Liam Huang via GitGitGadget's message of "Tue, 07 Jan 2020 10:02:56 +0000")
"Liam Huang via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Liam Huang <Liam0205@users.noreply.github.com>
>
> Some APIs have been changed since OpenSSL 1.1.0, so fix incompatibilities with OpenSSL 1.1.x.
I wonder if the patch can be made a lot less noisy with something
along this line
#if OPENSSL_VERSION_NUMBER < 0x10100000L
#define OPENSSL_sk_num(x) sk_GENERAL_NAME_num(x)
#define OPENSSL_sk_value(x,y) sk_GENERAL_NAME_value((x),(y))
#define OPENSSL_sk_pop_free(x,y) sk_GENERAL_NAME_pop_free((x),(y))
#endif
which would allow you to reduce many #if/#else/#endif in the actual
code.
next prev parent reply other threads:[~2020-01-07 20:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 10:02 [PATCH 0/1] Update imap-send.c, fix incompatibilities with OpenSSL 1.1.x Liam Huang via GitGitGadget
2020-01-07 10:02 ` [PATCH 1/1] " Liam Huang via GitGitGadget
2020-01-07 20:19 ` Junio C Hamano [this message]
2020-01-07 12:19 ` [PATCH 0/1] " Johannes Schindelin
2020-01-07 17:01 ` Junio C Hamano
2020-01-07 18:48 ` Johannes Schindelin
2020-01-07 19:57 ` Junio C Hamano
2020-01-07 20:15 ` Junio C Hamano
2020-01-08 10:59 ` Johannes Schindelin
2020-01-08 16:09 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpnfv3tq4.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).