git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Noam Yorav-Raphael via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org, Noam Yorav-Raphael <noamraph@gmail.com>
Subject: Re: [PATCH v3] docs: improve the example that illustrates git-notes path names
Date: Mon, 03 Aug 2020 12:39:12 -0700	[thread overview]
Message-ID: <xmqqpn87v7rz.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200803191139.GA68002@syl.lan> (Taylor Blau's message of "Mon, 3 Aug 2020 15:11:39 -0400")

Taylor Blau <me@ttaylorr.com> writes:

> On Mon, Aug 03, 2020 at 07:10:15PM +0000, Noam Yorav-Raphael via GitGitGadget wrote:
>> From: Noam Yorav-Raphael <noamraph@gmail.com>
>>
>> Make it clear that the filename has only the rest of the object ID,
>> not the entirety of it.
>>
>> Signed-off-by: Noam Yorav-Raphael <noamraph@gmail.com>
>> ---
>>     Improve the example that illustrates git-notes path names
>>
>>     docs: improve the example that illustrates git-notes path names
>>
>>     Make it clear that the filename has only the rest of the object ID, not
>>     the entirety of it.
>>
>>     Changes since v1:
>>
>>      * Improved the commit message, according to comments by Taylor Blau.
>>      * Changed the parts to random hex, so the '...' won't be confusing,
>>        according to suggestion by Junio C Hamano.
>>
>> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-692%2Fnoamraph%2Fclearer-notes-path-doc-v3
>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-692/noamraph/clearer-notes-path-doc-v3
>> Pull-Request: https://github.com/gitgitgadget/git/pull/692
>>
>> Range-diff vs v2:
>>
>>  1:  8b3defb657 ! 1:  e973e321d8 docs: improve the example that illustrates git-notes path names
>>      @@ Documentation/git-notes.txt: are taken from notes refs.  A notes ref is usually
>>        they describe, with some directory separators included for performance
>>        reasons footnote:[Permitted pathnames have the form
>>       -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory
>>      -+'12'`/`'34'`/`'56'`/`'...'`/`'789abc...': a sequence of directory
>>      ++'bf'`/`'fe'`/`'30'`/`'...'`/`'680d5a...': a sequence of directory
>>        names of two hexadecimal digits each followed by a filename with the
>>        rest of the object ID.].
>>
>>
>>
>>  Documentation/git-notes.txt | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/git-notes.txt b/Documentation/git-notes.txt
>> index ced2e8280e..0a4200674c 100644
>> --- a/Documentation/git-notes.txt
>> +++ b/Documentation/git-notes.txt
>> @@ -223,7 +223,7 @@ are taken from notes refs.  A notes ref is usually a branch which
>>  contains "files" whose paths are the object names for the objects
>>  they describe, with some directory separators included for performance
>>  reasons footnote:[Permitted pathnames have the form
>> -'ab'`/`'cd'`/`'ef'`/`'...'`/`'abcdef...': a sequence of directory
>> +'bf'`/`'fe'`/`'30'`/`'...'`/`'680d5a...': a sequence of directory
>>  names of two hexadecimal digits each followed by a filename with the
>>  rest of the object ID.].
>>
>>
>> base-commit: 85b4e0a6dc8407de6f69808d9ee6debdf167ced3
>> --
>> gitgitgadget
>
> Looks good to me, but Junio should chime in, too.
>
>   Acked-by: Taylor Blau <me@ttaylorr.com>

Yeah, thanks, both.

      reply	other threads:[~2020-08-03 19:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03 14:43 [PATCH] " Noam Yorav-Raphael via GitGitGadget
2020-08-03 15:48 ` Taylor Blau
2020-08-03 17:04   ` Junio C Hamano
2020-08-03 17:13     ` Taylor Blau
2020-08-03 16:21 ` [PATCH v2] " Noam Yorav-Raphael via GitGitGadget
2020-08-03 16:31   ` Taylor Blau
2020-08-03 19:10   ` [PATCH v3] " Noam Yorav-Raphael via GitGitGadget
2020-08-03 19:11     ` Taylor Blau
2020-08-03 19:39       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqpn87v7rz.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=me@ttaylorr.com \
    --cc=noamraph@gmail.com \
    --subject='Re: [PATCH v3] docs: improve the example that illustrates git-notes path names' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).