mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <>
To: Patrick Steinhardt <>
Cc: Jeff King <>,
Subject: Re: [PATCH] refs: fix interleaving hook calls with reference-transaction hook
Date: Fri, 07 Aug 2020 10:32:26 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <> (Patrick Steinhardt's message of "Fri, 7 Aug 2020 11:49:46 +0200")

Patrick Steinhardt <> writes:

> On Fri, Aug 07, 2020 at 05:32:39AM -0400, Jeff King wrote:
>> That implies you're just seeing noise. And indeed, with the patch below
>> I get:
>> Test                         HEAD^             HEAD
>> --------------------------------------------------------------------
>> 1400.2: update-ref           1.93(1.57+0.42)   1.91(1.55+0.42) -1.0%
>> 1400.3: update-ref --stdin   0.07(0.02+0.05)   0.07(0.02+0.05) +0.0%
>> Running it a second time gets me +0.5%. :)
> Yeah, it's also been my take that OS-level overhead is probably going to
> matter more than those access calls, and I argued such back when I
> proposed the hook. So I'm perfectly happy to see this caching mechanism
> go.

Is the above about negative cache?  IOW, does the above demonstrate
that one extra access() to make sure there is no hook does not hurt
us anything?  

If so, yes, I am 100% for removing the cache mechanism.

Thanks for driving design decision with numbers.  That's always
pleasant to see.

  reply	other threads:[~2020-08-07 17:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-07  7:05 [PATCH] refs: fix interleaving hook calls with reference-transaction hook Patrick Steinhardt
2020-08-07  7:58 ` Jeff King
2020-08-07  9:04   ` Patrick Steinhardt
2020-08-07  9:32     ` Jeff King
2020-08-07  9:49       ` Patrick Steinhardt
2020-08-07 17:32         ` Junio C Hamano [this message]
2020-08-07 19:00           ` Jeff King
2020-08-07 18:21         ` Jeff King
2020-08-07 19:26           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).