From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] refs: fix interleaving hook calls with reference-transaction hook
Date: Fri, 07 Aug 2020 10:32:26 -0700 [thread overview]
Message-ID: <xmqqpn82gy51.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20200807094946.GA1758126@tanuki.pks.im> (Patrick Steinhardt's message of "Fri, 7 Aug 2020 11:49:46 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> On Fri, Aug 07, 2020 at 05:32:39AM -0400, Jeff King wrote:
>
>> That implies you're just seeing noise. And indeed, with the patch below
>> I get:
>>
>> Test HEAD^ HEAD
>> --------------------------------------------------------------------
>> 1400.2: update-ref 1.93(1.57+0.42) 1.91(1.55+0.42) -1.0%
>> 1400.3: update-ref --stdin 0.07(0.02+0.05) 0.07(0.02+0.05) +0.0%
>>
>> Running it a second time gets me +0.5%. :)
>
> Yeah, it's also been my take that OS-level overhead is probably going to
> matter more than those access calls, and I argued such back when I
> proposed the hook. So I'm perfectly happy to see this caching mechanism
> go.
Is the above about negative cache? IOW, does the above demonstrate
that one extra access() to make sure there is no hook does not hurt
us anything?
If so, yes, I am 100% for removing the cache mechanism.
Thanks for driving design decision with numbers. That's always
pleasant to see.
next prev parent reply other threads:[~2020-08-07 17:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 7:05 [PATCH] refs: fix interleaving hook calls with reference-transaction hook Patrick Steinhardt
2020-08-07 7:58 ` Jeff King
2020-08-07 9:04 ` Patrick Steinhardt
2020-08-07 9:32 ` Jeff King
2020-08-07 9:49 ` Patrick Steinhardt
2020-08-07 17:32 ` Junio C Hamano [this message]
2020-08-07 19:00 ` Jeff King
2020-08-07 18:21 ` Jeff King
2020-08-07 19:26 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpn82gy51.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).