From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH v2 0/5] tests: migrate to "test-tool pkt-line"
Date: Mon, 12 Jul 2021 13:41:13 -0700 [thread overview]
Message-ID: <xmqqpmvn2rkm.fsf@gitster.g> (raw)
In-Reply-To: <cover-0.5-00000000000-20210712T164208Z-avarab@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Mon, 12 Jul 2021 18:44:15 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> This series is marked for "will merge to next" already, but not there
> yet. A trivial v2 whitespace fix in case Junio's in time to pick it
> up.
>
> See v1 at https://lore.kernel.org/git/cover-0.5-00000000000-20210707T101549Z-avarab@gmail.com/
>
> Ævar Arnfjörð Bjarmason (5):
> serve tests: add missing "extra delim" test
> serve tests: use test_cmp in "protocol violations" test
> tests: replace [de]packetize() shell+perl test-tool pkt-line
> tests: replace remaining packetize() with "test-tool pkt-line"
> test-lib-functions.sh: remove unused [de]packetize() functions
>
> t/helper/test-pkt-line.c | 12 +++++
> t/t5410-receive-pack-alternates.sh | 42 +++++++++++++-----
> t/t5411/once-0010-report-status-v1.sh | 12 ++---
> t/t5500-fetch-pack.sh | 15 ++++---
> t/t5530-upload-pack-error.sh | 24 +++++-----
> t/t5562-http-backend-content-length.sh | 16 ++++---
> t/t5570-git-daemon.sh | 22 ++++++----
> t/t5704-protocol-violations.sh | 61 ++++++++++++++++++--------
> t/test-lib-functions.sh | 42 ------------------
> 9 files changed, 135 insertions(+), 111 deletions(-)
>
> Range-diff against v1:
> 1: fcb53980597 = 1: 67aa8141153 serve tests: add missing "extra delim" test
> 2: c3544fb53cd = 2: 64dfd14865c serve tests: use test_cmp in "protocol violations" test
> 3: c1015fa6ab0 = 3: c33f344ab20 tests: replace [de]packetize() shell+perl test-tool pkt-line
> 4: ab23513b48b ! 4: a44e1790f2a tests: replace remaining packetize() with "test-tool pkt-line"
> @@ t/helper/test-pkt-line.c: static void pack(int argc, const char **argv)
>
> +static void pack_raw_stdin(void)
> +{
> -+
> + struct strbuf sb = STRBUF_INIT;
> + strbuf_read(&sb, 0, 0);
> + if (strbuf_read(&sb, 0, 0) < 0)
> 5: 2d22b83971a = 5: cc91d15ef70 test-lib-functions.sh: remove unused [de]packetize() functions
Well, if you care that much, I'd prefer to also see an blank line
between the end of decl and the first statement.
;-)
next prev parent reply other threads:[~2021-07-12 20:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-07 10:21 [PATCH 0/5] tests: migrate to "test-tool pkt-line" Ævar Arnfjörð Bjarmason
2021-07-07 10:21 ` [PATCH 1/5] serve tests: add missing "extra delim" test Ævar Arnfjörð Bjarmason
2021-07-07 10:21 ` [PATCH 2/5] serve tests: use test_cmp in "protocol violations" test Ævar Arnfjörð Bjarmason
2021-07-07 10:21 ` [PATCH 3/5] tests: replace [de]packetize() shell+perl test-tool pkt-line Ævar Arnfjörð Bjarmason
2021-07-07 10:21 ` [PATCH 4/5] tests: replace remaining packetize() with "test-tool pkt-line" Ævar Arnfjörð Bjarmason
2021-07-07 10:21 ` [PATCH 5/5] test-lib-functions.sh: remove unused [de]packetize() functions Ævar Arnfjörð Bjarmason
2021-07-12 16:44 ` [PATCH v2 0/5] tests: migrate to "test-tool pkt-line" Ævar Arnfjörð Bjarmason
2021-07-12 16:44 ` [PATCH v2 1/5] serve tests: add missing "extra delim" test Ævar Arnfjörð Bjarmason
2021-07-12 16:44 ` [PATCH v2 2/5] serve tests: use test_cmp in "protocol violations" test Ævar Arnfjörð Bjarmason
2021-07-12 16:44 ` [PATCH v2 3/5] tests: replace [de]packetize() shell+perl test-tool pkt-line Ævar Arnfjörð Bjarmason
2021-07-13 20:50 ` Jeff King
2021-07-13 23:41 ` Ævar Arnfjörð Bjarmason
2021-07-14 1:12 ` Jeff King
2021-07-12 16:44 ` [PATCH v2 4/5] tests: replace remaining packetize() with "test-tool pkt-line" Ævar Arnfjörð Bjarmason
2021-07-13 20:58 ` Jeff King
2021-07-13 23:52 ` Ævar Arnfjörð Bjarmason
2021-07-14 1:16 ` Jeff King
2021-07-12 16:44 ` [PATCH v2 5/5] test-lib-functions.sh: remove unused [de]packetize() functions Ævar Arnfjörð Bjarmason
2021-07-12 20:41 ` Junio C Hamano [this message]
2021-07-13 21:00 ` [PATCH v2 0/5] tests: migrate to "test-tool pkt-line" Jeff King
2021-07-14 0:54 ` [PATCH v3 " Ævar Arnfjörð Bjarmason
2021-07-14 0:54 ` [PATCH v3 1/5] serve tests: add missing "extra delim" test Ævar Arnfjörð Bjarmason
2021-07-14 0:54 ` [PATCH v3 2/5] serve tests: use test_cmp in "protocol violations" test Ævar Arnfjörð Bjarmason
2021-07-14 0:54 ` [PATCH v3 3/5] tests: replace [de]packetize() shell+perl test-tool pkt-line Ævar Arnfjörð Bjarmason
2021-07-14 4:04 ` Taylor Blau
2021-07-14 16:22 ` Junio C Hamano
2021-07-14 0:54 ` [PATCH v3 4/5] tests: replace remaining packetize() with "test-tool pkt-line" Ævar Arnfjörð Bjarmason
2021-07-14 0:54 ` [PATCH v3 5/5] test-lib-functions.sh: remove unused [de]packetize() functions Ævar Arnfjörð Bjarmason
2021-07-16 15:41 ` [PATCH v4] test-lib-functions: use test-tool for [de]packetize() Ævar Arnfjörð Bjarmason
2021-07-16 16:53 ` Taylor Blau
2021-07-16 19:08 ` Jeff King
2021-07-16 19:03 ` Jeff King
2021-07-19 18:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpmvn2rkm.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).