From: Junio C Hamano <gitster@pobox.com>
To: Eric Wong <e@80x24.org>
Cc: Jeff King <peff@peff.net>,
git@vger.kernel.org, Eric Sunshine <sunshine@sunshineco.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH] tests: disable fsync everywhere
Date: Fri, 29 Oct 2021 11:12:06 -0700 [thread overview]
Message-ID: <xmqqpmrnlmyx.fsf@gitster.g> (raw)
In-Reply-To: <20211029075640.M183252@dcvr> (Eric Wong's message of "Fri, 29 Oct 2021 07:56:40 +0000")
Eric Wong <e@80x24.org> writes:
> Junio C Hamano <gitster@pobox.com> wrote:
>> Eric Wong <e@80x24.org> writes:
>> > +# n.b. consider using Git.pm
>> > +sub use_fsync {
>> > + if (!defined($_use_fsync)) {
>> > + my $x = $ENV{GIT_TEST_FSYNC};
>> > + if (defined $x) {
>>
>> I would have expected to see "exists $ENV{GIT_TEST_FSYNC}", but I
>> guess there is no way to place in %ENV anyway, so it would be OK.
>
> Was that meant to say: "no way to place `undef' in %ENV anyway"?
Yes. Nothing the external callers of a Perl script does by futzing
the environment with setenv(3) and unsetenv(3) can make undef appear
as a value in $ENV{SomeKey}, so defined $ENV{V} and exists $ENV{V}
are equivalent.
I still prefer "exists $ENV{V}", which I think conveys the intent of
the check better, i.e. "we do this iff the environment variable X is
there".
> If so, `undef' can actually be in Perl's %ENV, though it appears
> to get coerced into "" (empty string) when spawning processes.
Yes, but you are talking about the opposite direction, what Perl can
do to %ENV to affect processes it spawns, which is not what I meant.
> Leaving GIT_CONFIG set was actually causing "git config" to
> exit(1) since git-cvsserver sets GIT_CONFIG and the GIT_CONFIG
> file doesn't have a test.fsync setting. This is the current
> behavior, I think it's a weird quirk, but intended behavior of
> git-config.
Ah, sorry, I misread the variable. GIT_CONFIG was the thing that
says "read from this file and nowhere else"; we do want to disable
it locally for "-c var=val" to take effect.
> # this assumes you don't have foo.bar set in your ~/.gitconfig :>
> $ GIT_CONFIG=$HOME/.gitconfig git -c foo.bar=0 config --type=bool foo.bar
> $ echo $?
> 1
>
>> > + my $v = ::safe_pipe_capture('git', '-c', "test.fsync=$x",
>> > + qw(config --type=bool test.fsync));
>>
>> THis is an interesting idiom.
>
> Heh, I just thought of it before sending my original. I was
> going to use a regexp originally (in git-svn, too), but didn't
> want to get into corner cases such as hex and +/- prefixes).
And this I think is the best way to do so ;-)
next prev parent reply other threads:[~2021-10-29 18:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 0:21 [PATCH] allow disabling fsync everywhere Eric Wong
2021-10-28 1:21 ` Eric Sunshine
2021-10-28 14:36 ` Jeff King
2021-10-28 18:28 ` Eric Wong
2021-10-28 19:29 ` Junio C Hamano
2021-10-29 0:15 ` [PATCH] tests: disable " Eric Wong
2021-10-29 5:18 ` Junio C Hamano
2021-10-29 7:56 ` Eric Wong
2021-10-29 18:12 ` Junio C Hamano [this message]
2021-10-29 7:33 ` Junio C Hamano
2021-10-29 7:48 ` Eric Wong
2021-10-29 17:22 ` Junio C Hamano
2021-10-29 20:34 ` Jeff King
2021-10-29 20:42 ` Junio C Hamano
2021-10-28 21:40 ` [PATCH] allow disabling " brian m. carlson
2021-10-29 11:20 ` Ævar Arnfjörð Bjarmason
2021-10-30 10:39 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpmrnlmyx.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).