From: Junio C Hamano <gitster@pobox.com>
To: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH 0/4] Really retire git-legacy-stash.sh
Date: Thu, 27 Jan 2022 17:59:41 -0800 [thread overview]
Message-ID: <xmqqpmocy60i.fsf@gitster.g> (raw)
In-Reply-To: <pull.1133.git.1643321031.gitgitgadget@gmail.com> (Johannes Schindelin via GitGitGadget's message of "Thu, 27 Jan 2022 22:03:47 +0000")
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:
> After proving out git stash for a very long time as a shell script, we
> eventually converted it to a proper built-in, leaving an escape hatch in
> place to call the scripted version.
>
> After another very long time, we removed that escape hatch, leaving behind a
> warning.
>
> Now, almost two years later, let's remove even that warning (and a couple of
> tidbits that we inadvertently left in the code base).
Yay. We probably could have done this when we disabled the escape
hatch, but better late than never ;-)
> Johannes Schindelin (4):
> git-sh-setup: remove remnant bits referring to `git-legacy-stash`
> add: remove support for `git-legacy-stash`
> Remove documentation for `stash.useBuiltin`
> stash: stop warning about the obsolete `stash.useBuiltin` config
> setting
>
> Documentation/config/stash.txt | 7 -------
> builtin/add.c | 14 --------------
> builtin/stash.c | 10 ----------
> git-sh-setup.sh | 1 -
> t/t3903-stash.sh | 15 ---------------
> 5 files changed, 47 deletions(-)
It is surprisingly small removal, but matches the explanation above,
i.e. the actual old implementation was gone long time ago.
Looking good.
Thanks.
prev parent reply other threads:[~2022-01-28 1:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 22:03 [PATCH 0/4] Really retire git-legacy-stash.sh Johannes Schindelin via GitGitGadget
2022-01-27 22:03 ` [PATCH 1/4] git-sh-setup: remove remnant bits referring to `git-legacy-stash` Johannes Schindelin via GitGitGadget
2022-01-27 22:03 ` [PATCH 2/4] add: remove support for `git-legacy-stash` Johannes Schindelin via GitGitGadget
2022-01-27 22:03 ` [PATCH 3/4] Remove documentation for `stash.useBuiltin` Johannes Schindelin via GitGitGadget
2022-01-27 22:03 ` [PATCH 4/4] stash: stop warning about the obsolete `stash.useBuiltin` config setting Johannes Schindelin via GitGitGadget
2022-01-28 1:59 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpmocy60i.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).