From: Junio C Hamano <gitster@pobox.com>
To: Glen Choo <chooglen@google.com>
Cc: git@vger.kernel.org, Benedek Kozma <cyberbeni@gmail.com>
Subject: Re: [PATCH] fetch: do not run a redundant fetch from submodule
Date: Mon, 16 May 2022 16:33:26 -0700 [thread overview]
Message-ID: <xmqqpmkdyrw9.fsf@gitster.g> (raw)
In-Reply-To: <kl6lr14thysl.fsf@chooglen-macbookpro.roam.corp.google.com> (Glen Choo's message of "Mon, 16 May 2022 15:56:26 -0700")
Glen Choo <chooglen@google.com> writes:
> IMO "&& remote" is non-inuitive enough to warrant a comment, e.g.
>
> /* do not update submodules if fetch_multiple() was called */
> if (!result && remote && (recurse_submodules != RECURSE_SUBMODULES_OFF)) {
As I am not so familiar with this codepath when submodules are
involved, I need to be explained why having called fetch_multiple()
means there is no need to update submodules".
/*
* This is only needed after fetch_one(), which does not
* fetch submodules by itself.
*
* fetch_multiple() has already updated submodules to grab
* commits necessary for the fetched history from each remote,
* so there is no need to fetch submodules from here.
*/
perhaps?
> The test looks good, but I think it belongs in
> t/t5526-fetch-submodules.sh. I don't see anything else in
> t5617-clone-submodules-remote.sh that calls "git fetch".
Good eyes.
> In addition, I think we need one more test that adds another remote. In
> the above test, we only have one remote, so we hit your new optimization
> and already pass the test without the need for "&& remote".
True, too.
next prev parent reply other threads:[~2022-05-16 23:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 14:46 Bugreport - submodules are fetched twice in some cases Benedek Kozma
2022-04-29 17:39 ` Junio C Hamano
2022-04-29 19:05 ` Glen Choo
2022-04-29 20:02 ` Junio C Hamano
2022-04-29 20:37 ` Glen Choo
2022-05-14 0:07 ` Glen Choo
2022-05-14 5:24 ` Junio C Hamano
2022-05-16 17:45 ` Glen Choo
2022-05-16 18:25 ` Junio C Hamano
2022-05-16 19:04 ` Junio C Hamano
2022-05-16 21:53 ` [PATCH] fetch: do not run a redundant fetch from submodule Junio C Hamano
2022-05-16 22:56 ` Glen Choo
2022-05-16 23:33 ` Junio C Hamano [this message]
2022-05-16 23:53 ` [PATCH v2] " Junio C Hamano
2022-05-17 16:47 ` Glen Choo
2022-05-18 15:53 ` Junio C Hamano
2022-05-14 0:15 ` Bugreport - submodules are fetched twice in some cases Glen Choo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpmkdyrw9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chooglen@google.com \
--cc=cyberbeni@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).