From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-0.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_CSS,URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id AF45F1F72A for ; Thu, 30 Jun 2022 21:23:20 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="dzsp9JTh"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236905AbiF3VSy (ORCPT ); Thu, 30 Jun 2022 17:18:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236381AbiF3VSx (ORCPT ); Thu, 30 Jun 2022 17:18:53 -0400 Received: from pb-smtp1.pobox.com (pb-smtp1.pobox.com [64.147.108.70]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C47245784 for ; Thu, 30 Jun 2022 14:18:52 -0700 (PDT) Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id C4A39135B12; Thu, 30 Jun 2022 17:18:50 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=WtJGQ19i0HQKSsztncvyzXqtGQu1kzzls9nzqc 2ylEk=; b=dzsp9JThS4IXxa7oiiC2hCnbk4CZvsrpVY45LKGY6fyzcIZkHgXPf0 mUY0M5tJ2NZvPUeH1ZuWDaYfjah5aGL+asJkdRZ13G/2rE7MUVRnvCQN/oZr/E6k qBS5+CbSWpidxOIggsNnkejbmE3E98GjIxHRbPzDuCgoiKDn8ioYw= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id B9B22135B11; Thu, 30 Jun 2022 17:18:50 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.82.80.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 2ECC6135B0F; Thu, 30 Jun 2022 17:18:50 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Siddharth Asthana Cc: git@vger.kernel.org Subject: Re: [PATCH 0/3] Add support for mailmap in cat-file References: <20220630142444.651948-1-siddharthasthana31@gmail.com> Date: Thu, 30 Jun 2022 14:18:47 -0700 In-Reply-To: <20220630142444.651948-1-siddharthasthana31@gmail.com> (Siddharth Asthana's message of "Thu, 30 Jun 2022 19:54:41 +0530") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 3C5EBBEE-F8BA-11EC-8F4B-5E84C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Siddharth Asthana writes: > So, this patch series adds mailmap support to the git cat-file command. > It does that by adding --[no-]use-mailmap command line option to the > git cat-file command. It also adds --[no-]mailmap option as an alias to > --[no-]use-mailmap. So does this kick in only with "git cat-file commit " and never with "git cat-file $type" for non-commit object types? For a payload like CREDITS file, people may want the blob contents filtered by applying the mailmap, so limiting it to only commits may or may not be the best idea. How does/should this interact with "git cat-file -p"? Does it also work with the batch mode? For a single-request-single-answer invocation like "git cat-file commit ", I think a "--[no-]use-mailmap" option is OK, but for something like the batch mode, we may want a way to obtain both the original and mapped name(s). E.g. with this option in effect, in addition to the "author" and "committer" headers of the commit, the output may get a "mailmap-author" and "mailmap-committer" fake headers that show the mapped idents. Soliciting too many questions mean the cover letter is doing a good job to pique interest from readers, and is not doing a good job to explain adequately what it really does ;-) Let's read on.