From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id A849C1F506 for ; Fri, 23 Sep 2022 17:05:40 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="WSbLGAi8"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229538AbiIWRFh (ORCPT ); Fri, 23 Sep 2022 13:05:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231184AbiIWRFe (ORCPT ); Fri, 23 Sep 2022 13:05:34 -0400 Received: from pb-smtp20.pobox.com (pb-smtp20.pobox.com [173.228.157.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09DF412BDBE for ; Fri, 23 Sep 2022 10:05:32 -0700 (PDT) Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id EF08A1B7C3D; Fri, 23 Sep 2022 13:05:31 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=VjwBK8M+yZRbf03lf3gzI/YE84MGurW9xWd6dF FsAn4=; b=WSbLGAi8OQhYqljEEDYzWXq7SoZdEUQxon/IB8wsV1riDM+4FiYln1 2JhIVH7IK+VYXmuQ7rPTIPP0G0VjVxr9yABOKi8kpmDbbKRArNsKCaBh3weTzWgD LnHC1iKkqOCjn12q4AAE4u4w4bwIfoiKm02q0UB9KdJcyyXQYJXfo= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id CFC671B7C3C; Fri, 23 Sep 2022 13:05:31 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.5.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id 674941B7C3A; Fri, 23 Sep 2022 13:05:28 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Derrick Stolee via GitGitGadget" Cc: git@vger.kernel.org, git@jeffhostetler.com, me@ttaylorr.com, chakrabortyabhradeep79@gmail.com, Derrick Stolee Subject: Re: [PATCH] pack-bitmap: remove trace2 region from hot path References: Date: Fri, 23 Sep 2022 10:05:27 -0700 In-Reply-To: (Derrick Stolee via GitGitGadget's message of "Fri, 23 Sep 2022 13:00:34 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: EC85733E-3B61-11ED-BDE3-C2DA088D43B2-77302942!pb-smtp20.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Derrick Stolee via GitGitGadget" writes: > - trace2_region_enter("pack-bitmap", "reading_lookup_table", the_repository); > /* NEEDSWORK: cache misses aren't recorded */ > bitmap = lazy_bitmap_for_commit(bitmap_git, commit); > - trace2_region_leave("pack-bitmap", "reading_lookup_table", the_repository); > if (!bitmap) > return NULL; > return lookup_stored_bitmap(bitmap); As "git blame" is bad in finding a piece of code that no longer exists, it may make sense to leave a comment around here why we do not have a trace2 region around this call, perhaps? + /* do not add trace2_region around here in the hot path */ bitmap = lazy_bitmap_for_commit(...); or something? Thanks.