From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 72B5F1F61A for ; Thu, 15 Dec 2022 00:21:54 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="I2/D86kf"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229527AbiLOAVw (ORCPT ); Wed, 14 Dec 2022 19:21:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230152AbiLOAVc (ORCPT ); Wed, 14 Dec 2022 19:21:32 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2736626E for ; Wed, 14 Dec 2022 16:21:18 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id g10so5123405plo.11 for ; Wed, 14 Dec 2022 16:21:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=NgXLcuZZQxxnxfEH5rqbus4uv1j3TO6GErCW0raOYak=; b=I2/D86kfL3gxfu/pZEv6fgHCWqWRx8nILUYo9J2+gP6mZgYKH8UkdEe63URHtrvMKd T0Mi+Xi/bKovCvdOg+vlFSzSK210MR62xNZrvxU15BZSzb+9GNST/joZsqD0paztXXWp v10rftO2EZMTICNygBzQQb7t8okkLO9ujY8WRQjnJePM0Wl4G9MgmqiJYOJsHUfALLx1 D8kGxjUfMMDWS9YSrcQwkMmPzrQFmJLkIbiPehVeduWB3EnCH4Mgd0mSlQiO6WcdPAz6 ZjkKPWlPyJx3sRplkd56F7M/V7dJc/4120upv2zmqXpbjVJr/8IwAkSs2yuWhMhuwsOn I1Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:sender:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=NgXLcuZZQxxnxfEH5rqbus4uv1j3TO6GErCW0raOYak=; b=rC3CG7tLCEus3KE7oX8HNavEtjUjnuTy8Vf3Hpqu51dibwYUaiV9Xb122ibh0+XSM1 eO/hKXw56zKlLtyk2PRM6OkCj7RDxRQ/hA1zqEJEnQAkr9CIkaRwMH1QKF0lGVIIdCVd VyJVnR7hPOgITkfXhJvDE7zTx5mSWk22D0ldeMIc5TfiMV1vXoCnZhrbZEfCCjdXtPL8 HAyu2qWUcpj/vWz4ggvlWin7fMolMZdTTSF3phg51ua3cOwoaIV0xs1CIJFK3eWjAE2D ewgj7dZKCjjU2vtimiF/v5snIsjNWGkDlYODENyfapy1NmiOse5lsPYrtSPRBoaGrL4O PknA== X-Gm-Message-State: AFqh2kp7IdPUKxIyPb51QR5fg4pkbsrymWTyNB5AVtpJ53PzIDVlQ8uv uPSOZBZMB+W7aix+fy8RM/Q= X-Google-Smtp-Source: AMrXdXskRF9m9xNm/Z3wR3Hwfs099ooAxXsxev5JETAGwivWRO15VXMjtNOYECC4u4hM9ydk5zeCsQ== X-Received: by 2002:a17:90b:210:b0:223:2edf:857e with SMTP id fy16-20020a17090b021000b002232edf857emr5612474pjb.8.1671063678372; Wed, 14 Dec 2022 16:21:18 -0800 (PST) Received: from localhost (33.5.83.34.bc.googleusercontent.com. [34.83.5.33]) by smtp.gmail.com with ESMTPSA id p9-20020a17090a284900b00219bf165b5fsm1932459pjf.21.2022.12.14.16.21.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 16:21:18 -0800 (PST) Sender: Junio C Hamano From: Junio C Hamano To: Victoria Dye Cc: Matthew John Cheetham via GitGitGadget , git@vger.kernel.org, Derrick Stolee , Lessley Dennington , Matthew John Cheetham , M Hickford , Jeff Hostetler , Glen Choo , Matthew John Cheetham Subject: Re: [PATCH v4 8/8] t5556: add HTTP authentication tests References: <8ecf63835229676677e3f7e33f634eb5d3a568b7.1670880984.git.gitgitgadget@gmail.com> <1dc44716-2550-47de-e666-9972b102905d@github.com> Date: Thu, 15 Dec 2022 09:21:17 +0900 In-Reply-To: <1dc44716-2550-47de-e666-9972b102905d@github.com> (Victoria Dye's message of "Wed, 14 Dec 2022 15:48:08 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Victoria Dye writes: > A general comment about this series - the way you have the patches organized > means that the "feature" content you're trying to integrate (the first two > patches) is contextually separated from these tests. For people that > learn/understand code via examples in tests, this makes it really difficult > to understand what's going on. To avoid that, I think you could rearrange > the patches pretty easily: > ... Thanks for a thorough review of the entire series, with concrete suggestions for improvements with encouragements sprinkled in. Very much appreciated.