From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: git@vger.kernel.org, "Cristian Le" <cristian.le@mpsd.mpg.de>,
"Matthias Görgens" <matthias.goergens@gmail.com>
Subject: Re: [PATCH v2] archive: improve support for running in subdirectory
Date: Mon, 27 Mar 2023 09:09:43 -0700 [thread overview]
Message-ID: <xmqqpm8uch14.fsf@gitster.g> (raw)
In-Reply-To: <7c33b01b-7b2a-25fa-9a66-1e65cd12bc84@web.de> ("René Scharfe"'s message of "Fri, 24 Mar 2023 23:27:11 +0100")
René Scharfe <l.s.r@web.de> writes:
> + /* rel can refer to path, so don't edit it in place */
> + strbuf_reset(&new_path);
> + strbuf_add(&new_path, args->base, args->baselen);
> + strbuf_addstr(&new_path, rel);
> + strbuf_swap(&path, &new_path);
Thanks. That indeed was nasty and tricky.
prev parent reply other threads:[~2023-03-27 16:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 10:25 Bug in git archive + .gitattributes + relative path Cristian Le
2023-03-03 15:19 ` René Scharfe
2023-03-03 15:38 ` Cristian Le
2023-03-04 13:58 ` René Scharfe
2023-03-04 15:11 ` Cristian Le
2023-03-05 9:32 ` René Scharfe
2023-03-06 16:56 ` Junio C Hamano
2023-03-06 17:51 ` René Scharfe
2023-03-06 17:27 ` Junio C Hamano
2023-03-06 18:28 ` René Scharfe
2023-03-06 18:59 ` Junio C Hamano
2023-03-06 21:32 ` René Scharfe
2023-03-06 22:34 ` Junio C Hamano
2023-03-11 20:47 ` René Scharfe
2023-03-12 21:25 ` Junio C Hamano
2023-03-18 21:30 ` René Scharfe
2023-03-20 16:16 ` Junio C Hamano
2023-03-20 20:02 ` [PATCH] archive: improve support for running in a subdirectory René Scharfe
2023-03-21 22:59 ` Junio C Hamano
2023-03-24 22:26 ` René Scharfe
2023-03-24 22:27 ` [PATCH v2] archive: improve support for running in subdirectory René Scharfe
2023-03-27 16:09 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpm8uch14.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=cristian.le@mpsd.mpg.de \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=matthias.goergens@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).