From: Junio C Hamano <gitster@pobox.com>
To: Teng Long <dyroneteng@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (May 2023, #03; Tue, 9)
Date: Wed, 10 May 2023 09:32:03 -0700 [thread overview]
Message-ID: <xmqqpm785erg.fsf@gitster.g> (raw)
In-Reply-To: <20230510071935.7329-1-tenglong.tl@alibaba-inc.com> (Teng Long's message of "Wed, 10 May 2023 15:19:35 +0800")
Teng Long <dyroneteng@gmail.com> writes:
>>* tl/notes-separator (2023-04-28) 6 commits
>> (merged to 'next' on 2023-05-06 at 598ed19c9b)
>> + notes.c: introduce "--[no-]stripspace" option
>> + notes.c: append separator instead of insert by pos
>> + notes.c: introduce '--separator=<paragraph-break>' option
>
> Sorry, there is an updated optimization for the commit of the
> `--separator` option, which can be applied using the reply[1].
>
> Please also inform me if a new patch is needed and I will send
> it immediately.
Once a topic is in 'next', we update by queuing a new patch on top,
so [1] is not quite sufficient.
As to the "char *" -> "const char *", I didn't check if there are
places where we use the variable as "char *" and need changes other
than the place the variable is defined to prevent compilers from
complaining on type mismatches when I made the observation, out of
which you made the change. In any case, "const char *" may be
safer, but the code as posted is not wrong per-se, and I do not see
it so urgent to fix.
The blank line also better sits between the decls and the first
statement, but I do not see it so urgent to fix with an immediate
patch, forging your sign-off and writing log message myself. It
is something we can safely leave for a separate clean-up topic after
the dust settles.
Thanks.
prev parent reply other threads:[~2023-05-10 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 1:56 What's cooking in git.git (May 2023, #03; Tue, 9) Junio C Hamano
2023-05-10 2:18 ` tb/pack-bitmap-index-seek Taylor Blau
2023-05-10 2:18 ` What's cooking in git.git (May 2023, #03; Tue, 9) Taylor Blau
2023-05-10 7:19 ` Teng Long
2023-05-10 16:32 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqpm785erg.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).