From: Junio C Hamano <gitster@pobox.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: Eric Sunshine <sunshine@sunshineco.com>, git@vger.kernel.org
Subject: A few "linked checkout" niggles
Date: Wed, 15 Jul 2015 16:13:35 -0700 [thread overview]
Message-ID: <xmqqoajdui8w.fsf@gitster.dls.corp.google.com> (raw)
I've tried to set up a non-bare clone of git.git at ~/w/src and
attached one of its branches to a separate work tree at ~/w/rerere
~/w/src$ git worktree add ../rerere jc/rerere
Then I tried the "multiple checkout not allowed".
~/w/src$ git checkout jc/rerere
fatal: 'jc/rerere' is already checked out at '/home/gitster/w/rerere/.git'
You see the first "niggle" above. Do we need "/.git" at the end?
That is hopefully merely cosmetic and I am guessing that we can
unconditionally drop "/.git" from the end, but maybe there are
subtle reasons why it may not be a good idea (e.g. introduces some
ambiguities?)
There is another, a more serious one.
~/w/src$ git fetch ../git.git jc/rerere:jc/rerere
This succeeds, without checking if there is a work tree that has it
checked out. I think the safety in "git fetch" that can be disabled
by "--update-head-ok" option should be updated to reuse the same
protection used by the updated "git checkout".
Something to work on for 2.5.x maintenance track, aiming for 2.5.1.
Thanks.
next reply other threads:[~2015-07-15 23:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 23:13 Junio C Hamano [this message]
2015-07-16 5:24 ` A few "linked checkout" niggles Duy Nguyen
2015-07-16 5:40 ` Eric Sunshine
2015-07-16 20:39 ` Junio C Hamano
2015-07-16 23:13 ` Duy Nguyen
2015-07-17 3:11 ` Eric Sunshine
2015-07-17 12:27 ` Michael J Gruber
2015-07-17 12:49 ` Duy Nguyen
2015-07-17 15:19 ` Junio C Hamano
2015-07-17 17:07 ` Eric Sunshine
2015-07-17 17:02 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoajdui8w.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).