From: Junio C Hamano <gitster@pobox.com>
To: Vasco Almeida <vascomalmeida@sapo.pt>
Cc: Alex Henrie <alexhenrie24@gmail.com>,
diane.gasselin@ensimag.imag.fr, Matthieu.Moy@imag.fr,
git@vger.kernel.org
Subject: Re: [PATCH] unpack-trees: fix English grammar in do-this-before-that messages
Date: Fri, 24 Jun 2016 15:28:07 -0700 [thread overview]
Message-ID: <xmqqoa6qdxxk.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <576D1BEA.8020509@sapo.pt> (Vasco Almeida's message of "Fri, 24 Jun 2016 11:39:22 +0000")
Vasco Almeida <vascomalmeida@sapo.pt> writes:
> The only downside I can tell about this is translator are going to have
> to update those strings on their translations, but that is a normal
> thing to do on an active project like Git.
A larger issue is this fails to update tests that check these
messages.
next prev parent reply other threads:[~2016-06-24 22:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 5:31 [PATCH] unpack-trees: fix English grammar in do-this-before-that messages Alex Henrie
2016-06-24 9:26 ` Matthieu Moy
2016-06-24 11:39 ` Vasco Almeida
2016-06-24 22:28 ` Junio C Hamano [this message]
2016-06-24 23:02 ` Vasco Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoa6qdxxk.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@imag.fr \
--cc=alexhenrie24@gmail.com \
--cc=diane.gasselin@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=vascomalmeida@sapo.pt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).