From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH v3 0/3] limit the size of the packs we receive
Date: Wed, 24 Aug 2016 12:30:46 -0700 [thread overview]
Message-ID: <xmqqoa4iotg9.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160824184157.19264-1-chriscool@tuxfamily.org> (Christian Couder's message of "Wed, 24 Aug 2016 20:41:54 +0200")
Christian Couder <christian.couder@gmail.com> writes:
> Diff with previous v2 version
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index f5b6061..8a115b3 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -2517,10 +2517,11 @@ receive.unpackLimit::
> especially on slow filesystems. If not set, the value of
> `transfer.unpackLimit` is used instead.
>
> -receive.maxsize::
> - If the size of a pack file is larger than this limit, then
> - git-receive-pack will error out, instead of accepting the pack
> - file. If not set or set to 0, then the size is unlimited.
> +receive.maxInputSize::
> + If the size of the incoming pack stream is larger than this
> + limit, then git-receive-pack will error out, instead of
> + accepting the pack file. If not set or set to 0, then the size
> + is unlimited.
>
> receive.denyDeletes::
> If set to true, git-receive-pack will deny a ref update that deletes
> diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
> ...
> diff --git a/t/t5546-receive-limits.sh b/t/t5546-receive-limits.sh
> new file mode 100755
> index 0000000..10cb0be
> --- /dev/null
> +++ b/t/t5546-receive-limits.sh
> @@ -0,0 +1,55 @@
> +#!/bin/sh
> + ...
> +test_done
> ---
>
> Christian Couder (1):
> unpack-objects: add --max-input-size=<size> option
>
> Jeff King (2):
> index-pack: add --max-input-size=<size> option
> receive-pack: allow a maximum input size to be specified
This was a pleasant read. All looked sensible.
Thanks.
prev parent reply other threads:[~2016-08-24 19:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-24 18:41 [PATCH v3 0/3] limit the size of the packs we receive Christian Couder
2016-08-24 18:41 ` [PATCH v3 1/3] index-pack: add --max-input-size=<size> option Christian Couder
2016-08-24 18:41 ` [PATCH v3 2/3] unpack-objects: " Christian Couder
2016-08-24 18:41 ` [PATCH v3 3/3] receive-pack: allow a maximum input size to be specified Christian Couder
2016-08-24 18:54 ` Jeff King
2016-08-24 19:30 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoa4iotg9.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).