From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>, git@vger.kernel.org
Subject: Re: [PATCH 0/2] Support `git reset --stdin`
Date: Tue, 11 Oct 2016 14:36:31 -0700 [thread overview]
Message-ID: <xmqqoa2q7elc.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161011212644.zzqidtcgatu3qsei@sigill.intra.peff.net> (Jeff King's message of "Tue, 11 Oct 2016 17:26:44 -0400")
Jeff King <peff@peff.net> writes:
>> If read-tree had pathspec support (i.e. "read these and only these
>> paths given from the command line into the index from a given
>> tree-ish"), that would have been the most natural place to extend
>> with "oh, by the way, instead of the command line, you can feed the
>> paths on the standard input".
>>
>> But it doesn't have one.
>
> True. I'd have done something more like:
>
> git ls-tree -r $paths | git update-index --index-info
>
> but there are some corner cases around deleting paths from the index.
Ah, I would think read-tree has the exact same issue, even if we
added pathspec support, around removal.
So it is more like
(
printf "0 0000000000000000000000000000000000000000\t%s\n" $paths
git --literal-pathspecs ls-tree -r --ignore-missing $paths
) | git update-index --index-info
which does not look too bad, even though this
printf "%s\n" $paths | git reset --stdin
does look shorter.
next prev parent reply other threads:[~2016-10-11 21:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 16:08 [PATCH 0/2] Support `git reset --stdin` Johannes Schindelin
2016-10-11 16:09 ` [PATCH 1/2] reset: fix usage Johannes Schindelin
2016-10-11 16:09 ` [PATCH 2/2] reset: support the --stdin option Johannes Schindelin
2016-10-11 17:53 ` Junio C Hamano
2016-10-12 12:57 ` Johannes Schindelin
2016-10-11 20:49 ` Jakub Narębski
2016-10-12 12:39 ` Johannes Schindelin
2016-10-11 18:34 ` [PATCH 0/2] Support `git reset --stdin` Jeff King
2016-10-11 19:27 ` Junio C Hamano
2016-10-11 21:26 ` Jeff King
2016-10-11 21:36 ` Junio C Hamano [this message]
2016-10-11 21:47 ` Jeff King
2016-10-11 21:49 ` Junio C Hamano
2017-01-27 12:38 ` [PATCH v2 0/1] " Johannes Schindelin
2017-01-27 12:38 ` [PATCH v2 1/1] reset: support the --stdin option Johannes Schindelin
2017-01-27 17:04 ` Jeff King
2017-01-27 17:34 ` Johannes Schindelin
2017-01-27 17:54 ` Jeff King
2017-01-27 18:30 ` Junio C Hamano
2017-01-27 22:12 ` Jeff King
2017-01-28 0:20 ` Junio C Hamano
2017-01-27 17:30 ` [PATCH v3 0/1] Support `git reset --stdin` Johannes Schindelin
2017-01-27 17:30 ` [PATCH v3 1/1] reset: support the --stdin option Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqoa2q7elc.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=johannes.schindelin@gmx.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).