From: Junio C Hamano <gitster@pobox.com>
To: git@jeffhostetler.com
Cc: git@vger.kernel.org, peff@peff.net, kewill@microsoft.com,
Kevin Willford <kewillf@microsoft.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH] name-hash: fix buffer overrun
Date: Fri, 31 Mar 2017 12:35:21 -0700 [thread overview]
Message-ID: <xmqqo9whxmrq.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170331173214.47514-2-git@jeffhostetler.com> (git@jeffhostetler.com's message of "Fri, 31 Mar 2017 17:32:14 +0000")
git@jeffhostetler.com writes:
> From: Kevin Willford <kewillf@microsoft.com>
>
> Add check for the end of the entries for the thread partition.
> Add test for lazy init name hash with specific directory structure
>
> The lazy init hash name was causing a buffer overflow when the last
> entry in the index was multiple folder deep with parent folders that
> did not have any files in them.
>
> This adds a test for the boundary condition of the thread partitions
> with the folder structure that was triggering the buffer overflow.
>
> The fix was to check if it is the last entry for the thread partition
> in the handle_range_dir and not try to use the next entry in the cache.
>
> Signed-off-by: Kevin Willford <kewillf@microsoft.com>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
>
> ---
Will queue with ...
> name-hash.c | 4 +++-
> t/t3008-ls-files-lazy-init-name-hash.sh | 19 +++++++++++++++++++
> 2 files changed, 22 insertions(+), 1 deletion(-)
> create mode 100644 t/t3008-ls-files-lazy-init-name-hash.sh
... this thing fixed by "chmod +x" (otherwise the tests won't start).
Thanks.
next prev parent reply other threads:[~2017-03-31 19:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 17:32 [PATCH] name-hash: fix buffer overrun git
2017-03-31 17:32 ` git
2017-03-31 19:35 ` Junio C Hamano [this message]
2017-03-31 21:18 ` Junio C Hamano
2017-03-31 23:18 ` Junio C Hamano
2017-04-01 4:12 ` Junio C Hamano
2017-04-01 12:12 ` Johannes Schindelin
2017-04-01 18:16 ` Junio C Hamano
2017-04-01 4:14 ` [PATCH] contrib/git-resurrect.sh: do not write \t for HT in sed scripts Junio C Hamano
2017-04-02 9:58 ` Jakub Narębski
2017-04-02 16:46 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo9whxmrq.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=jeffhost@microsoft.com \
--cc=johannes.schindelin@gmx.de \
--cc=kewill@microsoft.com \
--cc=kewillf@microsoft.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).