git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"Brandon Williams" <bmwill@google.com>
Subject: Re: [RFC/PATCH 2/3] wildmatch: add interface for precompiling wildmatch() patterns
Date: Sat, 24 Jun 2017 11:13:25 -0700	[thread overview]
Message-ID: <xmqqo9td9rui.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <87zicx1wig.fsf@gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Sat, 24 Jun 2017 12:59:51 +0200")

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> On Sat, Jun 24 2017, Junio C. Hamano jotted:
>
>> Is the far-in-the-future vision to make this the other way around?
>> That is, this being scaffolding, wildmatch_match() which is supposed
>> to be precompiled match actually uses wildmatch() as its underlying
>> engine, but when a viable compilation machinery is plugged in, the
>> wildmatch_match() that takes a precompiled pattern will call into
>> the machinery to execute the compiled pattern, and wildmatch() will
>> be reimplemented as "compile, call wildmatch_match() once and
>> discard" sequence?
>
> Exactly there would be no functional difference in the results, only
> fixed overhead.

OK, good!

Thanks.


  reply	other threads:[~2017-06-24 18:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-22 21:38 [PATCH 0/3] wildmatch refactoring Ævar Arnfjörð Bjarmason
2017-06-22 21:38 ` [PATCH 1/3] wildmatch: remove unused wildopts parameter Ævar Arnfjörð Bjarmason
2017-06-22 21:38 ` [RFC/PATCH 2/3] wildmatch: add interface for precompiling wildmatch() patterns Ævar Arnfjörð Bjarmason
2017-06-24  1:39   ` Junio C Hamano
2017-06-24 10:59     ` Ævar Arnfjörð Bjarmason
2017-06-24 18:13       ` Junio C Hamano [this message]
2017-06-22 21:38 ` [RFC/PATCH 3/3] wildmatch: make use of the " Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo9td9rui.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=bmwill@google.com \
    --cc=git@vger.kernel.org \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).