git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Job Snijders <job@instituut.net>
Cc: "Giuseppe Bilotta" <giuseppe.bilotta@gmail.com>,
	"Git List" <git@vger.kernel.org>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	yashi@atmark-techno.com, "Jakub Narebski" <jnareb@gmail.com>
Subject: Re: [PATCH] Add 'raw' blob_plain link in history overview
Date: Tue, 22 Aug 2017 12:22:43 -0700	[thread overview]
Message-ID: <xmqqo9r72yrg.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170821141306.wnlfn5a4hmgnj3yn@hanna.meerval.net> (Job Snijders's message of "Mon, 21 Aug 2017 16:13:06 +0200")

Job Snijders <job@instituut.net> writes:

> Add 'raw' blob_plain link in history overview
>
> Reviewed-by: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
> Signed-off-by: Job Snijders <job@instituut.net>
>
> ---

Thanks; I somehow thought that your earlier one not just said what
it does (twice---that is not needed) but why this change is useful,
but that is lost in the patch description?

>  gitweb/gitweb.perl | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index 9208f42ed..959f04b49 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -5967,6 +5967,9 @@ sub git_history_body {
>  		      $cgi->a({-href => href(action=>"commitdiff", hash=>$commit)}, "commitdiff");
>  
>  		if ($ftype eq 'blob') {
> +			print " | " .
> +			      $cgi->a({-href => href(action=>"blob_plain", hash_base=>$commit, file_name=>$file_name)}, "raw");
> +
>  			my $blob_current = $file_hash;
>  			my $blob_parent  = git_get_hash_by_path($commit, $file_name);
>  			if (defined $blob_current && defined $blob_parent &&

  reply	other threads:[~2017-08-22 19:22 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-02 18:59 [PATCH] Add 'raw' blob_plain link in history overview Job Snijders
2017-08-20 18:03 ` Job Snijders
2017-08-21 10:19   ` Giuseppe Bilotta
2017-08-21 10:44     ` Job Snijders
2017-08-21 14:07       ` Giuseppe Bilotta
2017-08-21 14:13         ` Job Snijders
2017-08-22 19:22           ` Junio C Hamano [this message]
2017-08-22 19:35             ` Job Snijders
2017-08-22 20:00               ` Giuseppe Bilotta
2017-08-22 20:07                 ` Job Snijders
2017-08-22 20:09                   ` Junio C Hamano
2017-08-22 20:06               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo9r72yrg.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=giuseppe.bilotta@gmail.com \
    --cc=jnareb@gmail.com \
    --cc=job@instituut.net \
    --cc=yashi@atmark-techno.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).