From: Junio C Hamano <gitster@pobox.com>
To: Mahmoud Al-Qudsi <mqudsi@neosmart.net>
Cc: git@vger.kernel.org
Subject: Re: Suggestion: better error message when an ambiguous checkout is executed
Date: Tue, 12 Sep 2017 15:53:17 +0900 [thread overview]
Message-ID: <xmqqo9qg1k82.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <xmqq8tivngkk.fsf@gitster.mtv.corp.google.com> (Junio C. Hamano's message of "Mon, 07 Aug 2017 15:44:43 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Mahmoud Al-Qudsi <mqudsi@neosmart.net> writes:
>
>> The default git behavior when attempting to `git checkout xxx` for
>> some value of "xxx" that cannot be resolved to a single, unique
>> file/path/branch/tag/commit/etc is to display the following:
> ...
> So a possible implementation approach would be
>
> - to let the current code do what it is doing
>
> - except that you add new code immediately before the code that
> issues 'xxx' did not match (i.e. the code already checked that
> 'xxx' taken as a pathspec does not match anything, and about to
> give the error message but hasn't done so just yet).
>
> - your new code
>
> . checks if 'xxx' could be an attempt to refer to a rev but
> insufficiently spelled out (e.g. both origin[12]/xxx exists, or
> for a bonus point, a similarly named origin/xxy exists and
> could be a typo).
>
> . if the above check found something, then you report it and
> terminate without complaining "pathspec 'xxx' did not
> match..."
>
> . on the other hand, if the above check did not find anything,
> then you let the current code issue the same error message as
> before.
I was sweeping my mailbox to collect loose ends that haven't been
tied down, and noticed that this topic does not seem to have reached
a conclusion. Do we want to reboot the effort? Or should we just
throw it in the #leftoverbits bin for now?
Thanks.
prev parent reply other threads:[~2017-09-12 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 21:49 Suggestion: better error message when an ambiguous checkout is executed Mahmoud Al-Qudsi
2017-08-07 22:44 ` Junio C Hamano
2017-09-12 6:53 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo9qg1k82.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mqudsi@neosmart.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).