From: Junio C Hamano <gitster@pobox.com>
To: Takuto Ikuta <tikuta@google.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] Use OBJECT_INFO_QUICK to speedup git fetch-pack
Date: Mon, 27 Nov 2017 13:35:35 +0900 [thread overview]
Message-ID: <xmqqo9noe3u0.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <0102015ffbbb2905-570eadd1-6b5c-46af-a3a9-bddfbd01c242-000000@eu-west-1.amazonses.com> (Takuto Ikuta's message of "Mon, 27 Nov 2017 04:27:47 +0000")
Takuto Ikuta <tikuta@google.com> writes:
> diff --git a/fetch-pack.c b/fetch-pack.c
> index 008b25d3db087..0184584e80599 100644
> --- a/fetch-pack.c
> +++ b/fetch-pack.c
> @@ -716,7 +716,7 @@ static int everything_local(struct fetch_pack_args *args,
> for (ref = *refs; ref; ref = ref->next) {
> struct object *o;
>
> - if (!has_object_file(&ref->old_oid))
> + if (!has_object_file_with_flags(&ref->old_oid, OBJECT_INFO_QUICK))
> continue;
>
It appears that great minds think alike?
cf. https://public-inbox.org/git/20171120202920.7ppcwmzkxifywtoj@sigill.intra.peff.net/
The 5-patch series that contains the same change as this one is
cooking and will hopefully be in the released version before the end
of the year.
next prev parent reply other threads:[~2017-11-27 4:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 4:27 [PATCH] Use OBJECT_INFO_QUICK to speedup git fetch-pack Takuto Ikuta
2017-11-27 4:35 ` Junio C Hamano [this message]
2017-11-27 4:37 ` Jeff King
2017-11-27 4:53 ` Junio C Hamano
2017-11-27 5:01 ` Takuto Ikuta
2017-11-27 21:24 ` Johannes Schindelin
2017-11-27 23:52 ` Junio C Hamano
2017-11-28 0:33 ` Johannes Schindelin
2017-11-28 1:58 ` Takuto Ikuta
2017-11-28 11:27 ` Johannes Schindelin
2017-11-28 11:35 ` Takuto Ikuta
2017-11-27 5:04 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo9noe3u0.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=tikuta@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).