From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep
Date: Mon, 12 Feb 2018 13:12:17 -0800 [thread overview]
Message-ID: <xmqqo9ktsyj2.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <xmqq3726t11d.fsf@gitster-ct.c.googlers.com> (Junio C. Hamano's message of "Mon, 12 Feb 2018 12:18:06 -0800")
Junio C Hamano <gitster@pobox.com> writes:
>> - test_i18ngrep -E '^(fatal|warning):' <error | grep -v 'hung up' >actual | sort &&
>> + grep -E '^(fatal|warning):' <error | grep -v 'hung up' >actual &&
>> test_i18ncmp expected actual
>
> OK, but not quite OK.
>
> Two grep invocations will not leave anything useful in 'actual'
> under poison build, and is almost guaranteed that 'expected' would
> not match, but that is perfectly OK because the final comparison is
> done.
Sorry. s/is done./is done with i18ncmp./ is what I wanted to say.
next prev parent reply other threads:[~2018-02-12 21:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 0:18 [PATCH 2/2] t5556: replace test_i18ngrep with a simple grep Ramsay Jones
2018-02-12 20:18 ` Junio C Hamano
2018-02-12 21:12 ` Junio C Hamano [this message]
2018-02-13 1:58 ` Ramsay Jones
2018-02-13 7:51 ` Junio C Hamano
2018-02-13 10:04 ` SZEDER Gábor
2018-02-13 17:08 ` Junio C Hamano
2018-02-13 17:26 ` Jeff King
2018-02-13 18:10 ` Junio C Hamano
2018-02-27 20:16 ` Junio C Hamano
2018-02-27 22:05 ` Junio C Hamano
2018-02-27 23:47 ` Ramsay Jones
2018-02-28 0:42 ` SZEDER Gábor
2018-02-28 15:33 ` Ramsay Jones
2018-02-28 16:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo9ktsyj2.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).