From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Stefan Beller <sbeller@google.com>
Subject: Re: [PATCH v2 0/6] reuse on-disk deltas for fetches with bitmaps
Date: Tue, 21 Aug 2018 12:34:18 -0700 [thread overview]
Message-ID: <xmqqo9dv8qf9.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20180821190622.GA30301@sigill.intra.peff.net> (Jeff King's message of "Tue, 21 Aug 2018 15:06:22 -0400")
Jeff King <peff@peff.net> writes:
> On Fri, Aug 17, 2018 at 04:54:27PM -0400, Jeff King wrote:
>
>> This series more aggressively reuses on-disk deltas to serve fetches
>> when reachability bitmaps tell us a more complete picture of what the
>> client has. That saves server CPU and results in smaller packs. See the
>> final patch for numbers and more discussion.
>
> Here's a v2, with just a few cosmetic fixes to address the comments on
> v1 (range-diff below).
>
> [1/6]: t/perf: factor boilerplate out of test_perf
> [2/6]: t/perf: factor out percent calculations
> [3/6]: t/perf: add infrastructure for measuring sizes
> [4/6]: t/perf: add perf tests for fetches from a bitmapped server
> [5/6]: pack-bitmap: save "have" bitmap from walk
> [6/6]: pack-objects: reuse on-disk deltas for thin "have" objects
Thanks.
> 1: 89fa0ec8d8 ! 1: 3e1b94d7d6 pack-bitmap: save "have" bitmap from walk
> @@ -69,6 +69,8 @@
> +
> + if (!bitmap_git)
> + return 0; /* no bitmap loaded */
> ++ if (!bitmap_git->result)
> ++ BUG("failed to perform bitmap walk before querying");
> + if (!bitmap_git->haves)
> + return 0; /* walk had no "haves" */
> +
The first four are unchanged, so this actually compares 5/6 of the
previous and the current one. Omitting the four identical ones
makes sense, but I wonder if it makes it easier to see if we keep
the number-label of the surviving patches.
> 2: f7ca0d59e3 ! 2: b8b2416aac pack-objects: reuse on-disk deltas for thin "have" objects
next prev parent reply other threads:[~2018-08-21 19:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 20:54 [PATCH 0/6] reuse on-disk deltas for fetches with bitmaps Jeff King
2018-08-17 20:55 ` [PATCH 1/6] t/perf: factor boilerplate out of test_perf Jeff King
2018-08-17 20:55 ` [PATCH 2/6] t/perf: factor out percent calculations Jeff King
2018-08-17 20:56 ` [PATCH 3/6] t/perf: add infrastructure for measuring sizes Jeff King
2018-08-17 20:57 ` [PATCH 4/6] t/perf: add perf tests for fetches from a bitmapped server Jeff King
2018-08-17 20:59 ` [PATCH 5/6] pack-bitmap: save "have" bitmap from walk Jeff King
2018-08-17 22:39 ` Stefan Beller
2018-08-17 22:45 ` Jeff King
2018-08-17 21:06 ` [PATCH 6/6] pack-objects: reuse on-disk deltas for thin "have" objects Jeff King
2018-08-17 22:57 ` Stefan Beller
2018-08-17 23:32 ` Jeff King
2018-08-20 21:03 ` Junio C Hamano
2018-08-20 21:42 ` Jeff King
2018-08-21 19:06 ` [PATCH v2 0/6] reuse on-disk deltas for fetches with bitmaps Jeff King
2018-08-21 19:08 ` Jeff King
2018-08-21 19:34 ` Junio C Hamano [this message]
2018-08-21 19:51 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo9dv8qf9.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).