From: Junio C Hamano <gitster@pobox.com>
To: "Randall S. Becker" <rsbecker@nexbridge.com>
Cc: "'Eric Sunshine'" <sunshine@sunshineco.us>,
<randall.s.becker@rogers.com>, "'Git List'" <git@vger.kernel.org>,
"'Randall S. Becker'" <randall.becker@nexbridge.ca>
Subject: Re: [Patch v5 2/4] config.mak.uname: support for modern HPE NonStop config.
Date: Thu, 03 Jan 2019 14:09:11 -0800 [thread overview]
Message-ID: <xmqqo98xfl6g.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <007901d4a3b0$5dd1d030$19757090$@nexbridge.com> (Randall S. Becker's message of "Thu, 3 Jan 2019 17:04:52 -0500")
"Randall S. Becker" <rsbecker@nexbridge.com> writes:
> On January 3, 2019 16:38, Eric Sunshine wrote:
>> On Thu, Jan 3, 2019 at 4:04 PM <randall.s.becker@rogers.com> wrote:
>> > A number of configuration options are not automatically detected by
>> > configure mechanisms, including the location of Perl and Python.
>> >
>> > There was a problem at a specific set of operating system versions
>> > that caused getopt to have compile errors. Account for this by
>> > providing emulation defines for those versions.
>> >
>> > Signed-off-by: Randall S. Becker <rsbecker@nexbridge.com>
>> > ---
>> > diff --git a/config.mak.uname b/config.mak.uname @@ -470,7 +487,7
>> @@
>> > ifeq ($(uname_S),NONSTOP_KERNEL)
>> > NO_MKDTEMP = YesPlease
>> > OLD_ICONV = UnfortunatelyYes
>> > - NO_REGEX = YesPlease
>> > + NO_REGEX=NeedsStartEnd
>> > NO_PTHREADS = UnfortunatelyYes
>>
>> Style nit (probably not worth a re-roll): you lost the whitespace surrounding
>> '='
>
> I can fix this one in the next round of changes, or after this gets in, if that works, or signoff on this being fixed in place.
I've already tweaked this while queuing. i.e. no need to resend
only to fix this one.
Thanks, both.
next prev parent reply other threads:[~2019-01-03 22:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 21:03 [Patch v5 0/4] HPE NonStop Port Commits randall.s.becker
2019-01-03 21:03 ` [Patch v5 1/4] transport-helper: use xread instead of read randall.s.becker
2019-01-03 21:03 ` [Patch v5 2/4] config.mak.uname: support for modern HPE NonStop config randall.s.becker
2019-01-03 21:38 ` Eric Sunshine
2019-01-03 22:04 ` Randall S. Becker
2019-01-03 22:09 ` Junio C Hamano [this message]
2019-01-03 21:03 ` [Patch v5 3/4] git-compat-util.h: add FLOSS headers for HPE NonStop randall.s.becker
2019-01-03 21:41 ` Eric Sunshine
2019-01-03 22:06 ` Randall S. Becker
2019-01-03 22:09 ` Junio C Hamano
2019-01-03 21:03 ` [Patch v5 4/4] compat/regex/regcomp.c: define intptr_t and uintptr_t on NonStop randall.s.becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo98xfl6g.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=randall.becker@nexbridge.ca \
--cc=randall.s.becker@rogers.com \
--cc=rsbecker@nexbridge.com \
--cc=sunshine@sunshineco.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).