git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: Johannes.Schindelin@gmx.de, git@vger.kernel.org
Subject: Re: jc/sequencer-stopped-sha-simplify, was Re: What's cooking in git.git (Oct 2020, #04; Tue, 27)
Date: Mon, 02 Nov 2020 10:51:44 -0800	[thread overview]
Message-ID: <xmqqo8kfvbgf.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201102184634.3280859-1-jonathantanmy@google.com> (Jonathan Tan's message of "Mon, 2 Nov 2020 10:46:34 -0800")

Jonathan Tan <jonathantanmy@google.com> writes:

>> I do not mind taking the approach as a prudent and careful thing,
>> but I want the question answered regardless, as I know Jonathan is
>> in a good position to tell if this is just a theoretical issue than
>> I am, and depending on the answer, we may rethink the approach of
>> trying to be overly careful.
>
> From what I see, this is just a theoretical issue for now. (I spotted it
> while looking at the code, not because of a bug report.)

If there is no actual damage, then probably the earlier "let's be
extra careful" Dscho mentioned may equally have been us being
unnecessarily cautious.  Assuming that you didn't apply this patch
to the internal version you ship to your developers---if you did,
then we truly gained no data from this exchange because the original
tightening had no chance to even cause the damage.

In any case, let's merge the loosening patch down to 'maint'.

Thanks for being careful.
.

  reply	other threads:[~2020-11-02 18:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 23:33 What's cooking in git.git (Oct 2020, #04; Tue, 27) Junio C Hamano
2020-11-02  1:47 ` jc/sequencer-stopped-sha-simplify, was " Johannes Schindelin
2020-11-02 18:34   ` Junio C Hamano
2020-11-02 18:46     ` Jonathan Tan
2020-11-02 18:51       ` Junio C Hamano [this message]
2020-11-02  1:50 ` jk/committer-date-is-author-date-fix-simplify, " Johannes Schindelin
2020-11-02 18:57   ` Junio C Hamano
2020-11-02  1:58 ` sj/untracked-files-in-submodule-directory-is-not-dirty, " Johannes Schindelin
2020-11-03  1:01   ` Junio C Hamano
2020-11-02  2:37 ` ag/merge-strategies-in-c, " Johannes Schindelin
2020-11-02 21:36   ` Junio C Hamano
2020-11-02 22:31     ` Alban Gruin
2020-11-03  0:32       ` Junio C Hamano
2020-11-04 13:22     ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo8kfvbgf.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=jonathantanmy@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).