git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Daniel Gurney <dgurney99@gmail.com>,
	git@vger.kernel.org,
	"brian m . carlson" <sandals@crustytoothpaste.net>,
	Jeff King <peff@peff.net>
Subject: Re: [PATCH] compat/bswap.h: don't assume MSVC is little-endian
Date: Wed, 11 Nov 2020 08:40:07 -0800	[thread overview]
Message-ID: <xmqqo8k34zko.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.2011111723050.18437@tvgsbejvaqbjf.bet> (Johannes Schindelin's message of "Wed, 11 Nov 2020 17:23:22 +0100 (CET)")

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

>> ...
>> So let's go back to the old way of detecting MSVC, and then checking
>> architecture from a list of little-endian architecture macros.
>>
>> Note that MSVC does not treat ARM64 as bi-endian, so we can safely treat
>> it as little-endian.
>>
>> Helped-by: brian m. carlson <sandals@crustytoothpaste.net>
>> Helped-by: Jeff King <peff@peff.net>
>> Helped-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
>> Helped-by: Junio C Hamano <gitster@pobox.com>
>> Signed-off-by: Daniel Gurney <dgurney99@gmail.com>
>
> ACK!
>
> Thank you so much,
> Dscho

Thanks, all.

      reply	other threads:[~2020-11-11 16:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-11  8:32 [PATCH] compat/bswap.h: don't assume MSVC is little-endian Daniel Gurney
2020-11-11 16:23 ` Johannes Schindelin
2020-11-11 16:40   ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo8k34zko.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=dgurney99@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).