git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Git List <git@vger.kernel.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Jeff King <peff@peff.net>,
	Emily Shaffer <emilyshaffer@google.com>
Subject: Re: [BUG?] "git config --replace-all key value value_regex" ignores value_regex?
Date: Wed, 18 Nov 2020 10:54:11 -0800	[thread overview]
Message-ID: <xmqqo8ju1ooc.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <466ee1d8-efaa-fc91-f3d9-230672289ffb@gmail.com> (Derrick Stolee's message of "Wed, 18 Nov 2020 13:07:29 -0500")

Derrick Stolee <stolee@gmail.com> writes:

> --replace-all::
> 	Default behavior is to replace at most one line. This replaces
> 	all lines matching the key (and optionally the value_regex).
>
> However, this test fails:
>
> test_expect_success '--replace-all and value_regex' '
> 	q_to_tab >.git/config <<-\EOF &&
> 	[abc]
> 	Qkey = one
> 	Qkey = two
> 	Qkey = three
> 	EOF
> 	q_to_tab >expect <<-\EOF &&
> 	[abc]
> 	Qkey = four
> 	Qkey = two
> 	Qkey = three
> 	EOF
> 	git config --replace-all abc.key four "o*" &&
> 	test_cmp expect .git/config
> '

I do not know or try to guess the original intention (I thought this
is Dscho's thing, no?), but if there are one/two/three and I were
asked to replace all of those that have zero or more 'o' in it with
'four' I would expect that

 (1) all three be removed, because they all have zero or more 'o',
     and then

 (2) one instance of 'four' be added,

resulting in a single 'four' left.

If the value_regex were "o+" (since it takes ERE) to mean one or
more, then my expectation would be

 (1) one and two be removed, because 'three' does not match, and
     then

 (2) one instance of 'four' be added,

resulting in two items, 'three' and 'four'.

An alternative interpretation would be that each of the removed
entries is replaced with a new one, resulting in three entries
(i.e. with "o*", it would leave three identical entries 'four',
with "o+", it would leave 'four', 'four' and 'three'), but that
may be less useful in practice.


  reply	other threads:[~2020-11-18 18:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-18 18:07 Derrick Stolee
2020-11-18 18:54 ` Junio C Hamano [this message]
2020-11-18 19:42   ` Derrick Stolee
2020-11-18 20:28     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqo8ju1ooc.fsf@gitster.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=emilyshaffer@google.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=stolee@gmail.com \
    --subject='Re: [BUG?] "git config --replace-all key value value_regex" ignores value_regex?' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).