From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 862CB1FB0D for ; Thu, 26 Nov 2020 01:08:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729200AbgKZBEx (ORCPT ); Wed, 25 Nov 2020 20:04:53 -0500 Received: from pb-smtp20.pobox.com ([173.228.157.52]:64020 "EHLO pb-smtp20.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728364AbgKZBEx (ORCPT ); Wed, 25 Nov 2020 20:04:53 -0500 Received: from pb-smtp20.pobox.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 644E3FDC9A; Wed, 25 Nov 2020 20:04:51 -0500 (EST) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=moe/0sOuoQrZ6zhE2TdBKtpohno=; b=fh0zMM fgWAgLaZl8HksJSM5LLj+84IMQKeCVjSNsf8bXodYEeCuvMkH1Jh+ad0FkRKiXJs 339udgzTwnCAT2+CF4CpyE3tfIdXvA+NQ+Nsxp/CqtNOJpRE5QyEXHDm+B4HiCGP K2GY7oW6Zu9C3dV9qBHFXWFayZQkIllQdJJts= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=cgdarVJgJRsMIIN3nJnyrH7VgZXLCJyX 7m/++pdb+uyQP6bacZwXtZSPcMcqbBRTYjHE82XkC81Ns2Hjk7lzeVFeirFHwhHe auFtEui37ppP5t7mosLRWk/EHVjC/m5VLV8h4GapjrRTrAdagRmEOmvCL40K3lzn ttGdfjnJPjw= Received: from pb-smtp20.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp20.pobox.com (Postfix) with ESMTP id 5D02DFDC99; Wed, 25 Nov 2020 20:04:51 -0500 (EST) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.75.7.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp20.pobox.com (Postfix) with ESMTPSA id A66E5FDC98; Wed, 25 Nov 2020 20:04:48 -0500 (EST) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jeff King Cc: =?utf-8?Q?Ren=C3=A9?= Scharfe , =?utf-8?B?5ZSQ5a6H5aWV?= , git@vger.kernel.org Subject: Re: Bug report: orphaned pack-objects after killing upload-pack on [ References: <20201121002921.GC353076@coredump.intra.peff.net> Date: Wed, 25 Nov 2020 17:04:47 -0800 In-Reply-To: (Jeff King's message of "Wed, 25 Nov 2020 19:53:12 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 61715F9C-2F83-11EB-9074-E43E2BB96649-77302942!pb-smtp20.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff King writes: > On Wed, Nov 25, 2020 at 01:42:24PM -0800, Junio C Hamano wrote: > >> In the meantime, I may queue this on 'seen' but it cannot move >> forward without a signoff. >> ... > We spawn an external pack-objects process to actually send objects to > the remote side. If we are killed by a signal during this process, > then pack-objects may continue to run. As soon as it starts producing > output for the pack, it will see a failure writing to upload-pack and > exit itself. But before then, it may do significant work traversing > the object graph, compressing deltas, etc, which will all be > pointless. So let's make sure to kill as soon as we know that the > caller will not read the result. Thanks, that reads well.