From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "René Scharfe" <l.s.r@web.de>, 唐宇奕 <winglovet@gmail.com>,
git@vger.kernel.org
Subject: Re: Bug report: orphaned pack-objects after killing upload-pack on [
Date: Wed, 25 Nov 2020 17:04:47 -0800
Message-ID: <xmqqo8jllyhc.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <X778eIAr3uzdh0H0@coredump.intra.peff.net> (Jeff King's message of "Wed, 25 Nov 2020 19:53:12 -0500")
Jeff King <peff@peff.net> writes:
> On Wed, Nov 25, 2020 at 01:42:24PM -0800, Junio C Hamano wrote:
>
>> In the meantime, I may queue this on 'seen' but it cannot move
>> forward without a signoff.
>> ...
> We spawn an external pack-objects process to actually send objects to
> the remote side. If we are killed by a signal during this process,
> then pack-objects may continue to run. As soon as it starts producing
> output for the pack, it will see a failure writing to upload-pack and
> exit itself. But before then, it may do significant work traversing
> the object graph, compressing deltas, etc, which will all be
> pointless. So let's make sure to kill as soon as we know that the
> caller will not read the result.
Thanks, that reads well.
next prev parent reply other threads:[~2020-11-26 1:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 8:18 唐宇奕
2020-11-20 18:52 ` Bug report: orphaned pack-objects after killing upload-pack on [was: (no subject)] René Scharfe
2020-11-21 0:29 ` Jeff King
2020-11-21 21:54 ` Bug report: orphaned pack-objects after killing upload-pack on [ Junio C Hamano
2020-11-24 3:21 ` 唐宇奕
2020-11-24 9:11 ` Jeff King
2020-11-25 21:42 ` Junio C Hamano
2020-11-26 0:53 ` Jeff King
2020-11-26 1:04 ` Junio C Hamano [this message]
2020-11-26 20:04 ` René Scharfe
2020-11-27 4:17 ` Jeff King
2020-11-27 20:43 ` René Scharfe
2020-11-28 6:30 ` Jeff King
2020-12-01 12:15 ` Jeff King
2020-12-02 11:45 ` René Scharfe
2020-12-02 22:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo8jllyhc.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=winglovet@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
git@vger.kernel.org list mirror (unofficial, one of many)
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://public-inbox.org/git
git clone --mirror http://ou63pmih66umazou.onion/git
git clone --mirror http://czquwvybam4bgbro.onion/git
git clone --mirror http://hjrcffqmbrq6wope.onion/git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V1 git git/ https://public-inbox.org/git \
git@vger.kernel.org
public-inbox-index git
Example config snippet for mirrors.
Newsgroups are available over NNTP:
nntp://news.public-inbox.org/inbox.comp.version-control.git
nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
nntp://news.gmane.io/gmane.comp.version-control.git
note: .onion URLs require Tor: https://www.torproject.org/
code repositories for the project(s) associated with this inbox:
https://80x24.org/mirrors/git.git
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git