From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: git@vger.kernel.org, Derrick Stolee <dstolee@microsoft.com>,
Jeff King <peff@peff.net>, Jonathan Nieder <jrnieder@gmail.com>,
Jonathan Tan <jonathantanmy@google.com>,
Taylor Blau <me@ttaylorr.com>
Subject: Re: [PATCH v2 0/1] And so it begins...merge/rename performance work
Date: Thu, 14 Jan 2021 11:08:50 -0800 [thread overview]
Message-ID: <xmqqo8hrxrnh.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20210113221158.2869128-1-newren@gmail.com> (Elijah Newren's message of "Wed, 13 Jan 2021 14:11:57 -0800")
Elijah Newren <newren@gmail.com> writes:
> This depends on a merge of en/ort-conflict-handling, en/diffcore-rename,
> and en/ort-directory-rename.
Thanks.
How ready is the foundation to accept this change? This will depend
on all of the above three topics and I am not sure what the status
of them is---I think that I've read through the diffcore-rename one
and it was a pleasant read, but I do not recall the reviewer
reactions to the other two.
It does not instill a lot of confidence in these topics that nobody
commented on things like [v2 17/17] of en/ort-directory-rename
(which fixes the code introduced in [v2 06/17] instead of fixing it
at the source before 06/17 copies it from elsewhere [*1*]). It
looks to me like a sign that these collection of series are moving
too fast than any reviewer to catch up.
Thanks.
[Footnote]
*1* I do not particularly think [06/17] that copies and leaves the
recursive backend behind is necessarily bad. What I find more
disturbing is that nobody seems to have a chance to give any
look to the two iterations of the series (as far as I can see,
v2 is just in name only---it removed 18/17 in v1 that were not
meant to be sent), and we are about to build on top of the
foundation that nobody knows how solid it is.
next prev parent reply other threads:[~2021-01-14 19:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-08 20:51 [PATCH 0/1] And so it begins...merge/rename performance work Elijah Newren
2021-01-08 20:51 ` [PATCH 1/1] merge-ort: begin performance work; instrument with trace2_region_* calls Elijah Newren
2021-01-08 20:59 ` Taylor Blau
2021-01-08 21:50 ` Elijah Newren
2021-01-08 21:55 ` Taylor Blau
2021-01-09 0:52 ` Elijah Newren
2021-01-13 22:11 ` [PATCH v2 0/1] And so it begins...merge/rename performance work Elijah Newren
2021-01-13 22:11 ` [PATCH v2 1/1] merge-ort: begin performance work; instrument with trace2_region_* calls Elijah Newren
2021-01-14 19:08 ` Junio C Hamano [this message]
2021-01-14 20:18 ` [PATCH v2 0/1] And so it begins...merge/rename performance work Elijah Newren
2021-01-15 19:29 ` [PATCH v3 " Elijah Newren
2021-01-15 19:29 ` [PATCH v3 1/1] merge-ort: begin performance work; instrument with trace2_region_* calls Elijah Newren
2021-01-24 6:01 ` [PATCH v4 0/3] And so it begins...merge/rename performance work Elijah Newren
2021-01-24 6:01 ` [PATCH v4 1/3] merge-ort: fix massive leak Elijah Newren
2021-01-24 19:11 ` Derrick Stolee
2021-01-24 6:01 ` [PATCH v4 2/3] merge-ort: ignore the directory rename split conflict for now Elijah Newren
2021-01-24 6:01 ` [PATCH v4 3/3] merge-ort: begin performance work; instrument with trace2_region_* calls Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo8hrxrnh.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
--cc=jrnieder@gmail.com \
--cc=me@ttaylorr.com \
--cc=newren@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).