From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Yaron Wittenstein <yaron.wittenstein@gmail.com>
Subject: Re: [PATCH v2 2/2] githooks.txt: Clarify documentation on reference-transaction hook
Date: Mon, 01 Mar 2021 08:54:15 -0800 [thread overview]
Message-ID: <xmqqo8g2stl4.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <55905b8693dd49637d0516ee123405cbfb58b6c6.1614591751.git.ps@pks.im> (Patrick Steinhardt's message of "Mon, 1 Mar 2021 10:43:55 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> The reference-transaction hook doesn't clearly document its scope and
> what values it receives as input. Document it to make it less surprising
> and clearly delimit its (current) scope.
Sounds good (especially "that may change in the future" part is a
nice touch).
Thanks.
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
> Documentation/githooks.txt | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/githooks.txt b/Documentation/githooks.txt
> index 4dad80052e..b51959ff94 100644
> --- a/Documentation/githooks.txt
> +++ b/Documentation/githooks.txt
> @@ -473,7 +473,8 @@ reference-transaction
>
> This hook is invoked by any Git command that performs reference
> updates. It executes whenever a reference transaction is prepared,
> -committed or aborted and may thus get called multiple times.
> +committed or aborted and may thus get called multiple times. The hook
> +does not cover symbolic references (but that may change in the future).
>
> The hook takes exactly one argument, which is the current state the
> given reference transaction is in:
> @@ -492,6 +493,14 @@ receives on standard input a line of the format:
>
> <old-value> SP <new-value> SP <ref-name> LF
>
> +where `<old-value>` is the old object name passed into the reference
> +transaction, `<new-value>` is the new object name to be stored in the
> +ref and `<ref-name>` is the full name of the ref. When force updating
> +the reference regardless of its current value or when the reference is
> +to be created anew, `<old-value>` is the all-zeroes object name. To
> +distinguish these cases, you can inspect the current value of
> +`<ref-name>` via `git rev-parse`.
> +
> The exit status of the hook is ignored for any state except for the
> "prepared" state. In the "prepared" state, a non-zero exit status will
> cause the transaction to be aborted. The hook will not be called with
prev parent reply other threads:[~2021-03-01 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 5:50 [PATCH] githooks.txt: Clarify documentation on reference-transaction hook Patrick Steinhardt
2021-02-26 6:03 ` Jeff King
2021-03-01 9:33 ` Patrick Steinhardt
2021-03-01 9:43 ` [PATCH v2 1/2] githooks.txt: Replace mentions of SHA-1 specific properties Patrick Steinhardt
2021-03-01 16:48 ` Junio C Hamano
2021-03-01 9:43 ` [PATCH v2 2/2] githooks.txt: Clarify documentation on reference-transaction hook Patrick Steinhardt
2021-03-01 16:54 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo8g2stl4.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=yaron.wittenstein@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).