From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 710A51F5AF for ; Tue, 30 Mar 2021 17:38:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232057AbhC3Rhw (ORCPT ); Tue, 30 Mar 2021 13:37:52 -0400 Received: from pb-smtp2.pobox.com ([64.147.108.71]:62284 "EHLO pb-smtp2.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231794AbhC3Rhi (ORCPT ); Tue, 30 Mar 2021 13:37:38 -0400 Received: from pb-smtp2.pobox.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 4C0F9BF681; Tue, 30 Mar 2021 13:37:37 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=yNoTdYO9wzCopTm3KA7Mz/DU+oM=; b=JtwyXE MEj8joapBdZajtzcQJkTCfihjW325buX9VeRGhIigo3K/N+7ClbSkfuCE2KJ4TDV lo47RHdKaiwdw6UIrnaTHevp9a0NprI3q11w+3++VFPPIlGao8fjRgb4AJbIpppX O8G749cxPb+E13pJTt5u5bPkFImA903dtvMB0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=j0ZDvBaxTqIN6pZrsCzeeDkKitVZYtq/ x7+x05gWJaVCI5+C+6Re1fTy07afqfFb+p5RukVfWFCTpO0+YEYpCr28OAOAzPrt 8gOfzsL1QrLWxAeL3Z8hTLkJK2ZX4G1E+HE8ZJ6s/PFRkNxxqrVYCdAYgejojDEm RtpsmQ1LjZw= Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp2.pobox.com (Postfix) with ESMTP id 43428BF680; Tue, 30 Mar 2021 13:37:37 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 7C7A6BF67E; Tue, 30 Mar 2021 13:37:36 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Stavros Ntentos Cc: git@vger.kernel.org, stdedos+git@gmail.com, bagasdotme@gmail.com, peff@peff.net Subject: Re: [PATCH v2] pathspec: advice: long and short forms are incompatible References: <20210328154532.23803-1-133706+stdedos@users.noreply.github.com> Date: Tue, 30 Mar 2021 10:37:35 -0700 In-Reply-To: (Junio C. Hamano's message of "Sun, 28 Mar 2021 12:12:05 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 9DDBAFAC-917E-11EB-B5FA-74DE23BA3BAF-77302942!pb-smtp2.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: >> +static const char mixed_pathspec_magic[] = N_( >> + "'%.*s...': cannot mix shortform magic with longform [e.g. like :(glob)].\n" > > OK. Just a bit of bikeshedding. > > cannot mix short and long form magic > cannot mix shortform magic with longform > > The former is a bit shorter. Also, if we show (with %.*s) the > actual beginning of their attempt, e.g. when they gave us [*] > > git show -- ':!(global,icase)foo' > > if we show > ... > ':!(...': cannot mix short and long form pathspec magic > > it may be sufficiently clear where the problem is. I meant "clear where the problem is, without adding [e.g. like :(glob)]". Thanks.