From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 24B2B1F4B4 for ; Fri, 2 Apr 2021 21:31:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235668AbhDBVbn (ORCPT ); Fri, 2 Apr 2021 17:31:43 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:56537 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234821AbhDBVbl (ORCPT ); Fri, 2 Apr 2021 17:31:41 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 098EAC8CA3; Fri, 2 Apr 2021 17:31:40 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=Mn+KSZuhF7xc T6jLaqd21mcy7VE=; b=sdFfYic4CcJy5tmsI2zLizxOUfaPaK3BwnNOduSCdJ+z 0twPTVyPw5U8CX8e9OzgrtKVtYVKgMtXC/pSgd7vjz6P6GIQ2vJK441Ql3tiQD+B ROI6trXCvnMFIMQVVRWHN0YpiwXKIu0PGkVQrsAZkQ1elUqX1v3NH1BwWa3z6kA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=MKuSZ9 vpCbUVgiXwEN91MyFksrb9sLghv4jBGRcpikNButkSBq97ClBwc6Js1bkmBE18Ce uN/+hXs5qf1TADKzk+liggwa2w3sp1wu7Dm9Rh3xq00FL32VNG9jZBBF63/dzpi2 0kyZPqt/2qO2O+WlZZslbxIV4JtzKT2yuADCo= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 01878C8CA2; Fri, 2 Apr 2021 17:31:40 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 89101C8CA1; Fri, 2 Apr 2021 17:31:39 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason Cc: git@vger.kernel.org, Emily Shaffer Subject: Re: [PATCH 1/2] git-send-email: replace "map" in void context with "for" References: Date: Fri, 02 Apr 2021 14:31:38 -0700 In-Reply-To: (=?utf-8?B?IsOGdmFyCUFybmZqw7Zyw7A=?= Bjarmason"'s message of "Fri, 2 Apr 2021 13:34:33 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Pobox-Relay-ID: CF6893B8-93FA-11EB-83BC-D152C8D8090B-77302942!pb-smtp1.pobox.com Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org =C3=86var Arnfj=C3=B6r=C3=B0 Bjarmason writes: > While using "map" instead of "for" or "map" instead of "grep" and > vice-versa makes for interesting trivia questions when interviewing > Perl programmers, it doesn't make for very readable code. Let's > refactor this loop initially added in 8fd5bb7f44b (git send-email: add > --annotate option, 2008-11-11) to be a for-loop instead. ;-) Will queue. Thanks.