From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id DD5E21F4B4 for ; Tue, 20 Apr 2021 23:37:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234382AbhDTXiP (ORCPT ); Tue, 20 Apr 2021 19:38:15 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:63440 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233992AbhDTXiP (ORCPT ); Tue, 20 Apr 2021 19:38:15 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id C5614118140; Tue, 20 Apr 2021 19:37:42 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=KdPrxGaN5ntCaAKWwM9j+XEWLwo=; b=ibS5nT TI8VuVhvR/HpbKIC+BRMjP9QQLepCllEOLTwZz+ika22OR5TAPYEaZFjqsKJdkjm HIEAPC74Hf6Is7IrNhf0Md/nhmp97LoW5kex8NMwJQ15ARVU4NOV7qwYbJAkhGIz rggDmaf8tbAt5UQ7IOTPm+FZNDXadPCAMLb9Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=eIHf5I4uTas0bQ6XH2clSqzMoV6Us3uh GBFIIG5WCpk1yhmUnW1LaB8GWFEAS99qKjwyywBvcFiXUWg9atKRoh0piPOI/Zmq 3YYpZyEiZZP/MnEl2FY3MV7DzzvDd22X2o97Cl/qPGHbl/YS+roI6eow79b5RtZT PI660Rydf1o= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id BE63D11813F; Tue, 20 Apr 2021 19:37:42 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.74.119.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 0F67311813E; Tue, 20 Apr 2021 19:37:39 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Han-Wen Nienhuys via GitGitGadget" Cc: git@vger.kernel.org, Han-Wen Nienhuys , Han-Wen Nienhuys Subject: Re: [PATCH 10/18] test-lib: provide test prereq REFFILES References: <3d3b733c31273a004e80d5cbab8f746a2010e9ea.1618829583.git.gitgitgadget@gmail.com> Date: Tue, 20 Apr 2021 16:37:38 -0700 In-Reply-To: (Junio C. Hamano's message of "Tue, 20 Apr 2021 15:57:35 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 6540B548-A231-11EB-865D-D609E328BF65-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Junio C Hamano writes: > "Han-Wen Nienhuys via GitGitGadget" writes: > >> From: Han-Wen Nienhuys >> >> REFFILES can be used to mark tests that are specific to the packed/loose ref >> storage format and its limitations. Marking such tests is a preparation for >> introducing the reftable storage backend. > > We'd want a bit of documentation either here or in t/README to > explain things like how these two interact with each other, if both > can be active at the same time, etc. By "here", I meant the place in the code where the test_set_prereq was added, not in the proposed log message that will become hard to see when test writers need to work with the sources. Thanks. > >> >> Signed-off-by: Han-Wen Nienhuys >> --- >> t/test-lib.sh | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/t/test-lib.sh b/t/test-lib.sh >> index d3f6af6a6545..ea7397c633db 100644 >> --- a/t/test-lib.sh >> +++ b/t/test-lib.sh >> @@ -1481,6 +1481,8 @@ parisc* | hppa*) >> ;; >> esac >> >> +test_set_prereq REFFILES >> + >> ( COLUMNS=1 && test $COLUMNS = 1 ) && test_set_prereq COLUMNS_CAN_BE_1 >> test -z "$NO_PERL" && test_set_prereq PERL >> test -z "$NO_PTHREADS" && test_set_prereq PTHREADS