From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Gregory Anders <greg@gpanders.com>, git@vger.kernel.org
Subject: Re: Syntax for specifying a command in git config
Date: Wed, 12 May 2021 07:56:47 +0900 [thread overview]
Message-ID: <xmqqo8dgj2vk.fsf@gitster.g> (raw)
In-Reply-To: <YJrKJAa45mNIL+rf@coredump.intra.peff.net> (Jeff King's message of "Tue, 11 May 2021 14:17:08 -0400")
Jeff King <peff@peff.net> writes:
>> Obviously this is not a *huge* deal, but it is a minor annoyance. I'm
>> wondering if it would be possible to add a new syntax to config options like
>> this. For example,
>>
>> [sendemail]
>> smtpServer = !msmtp
>>
>> The leading ! character says "the following value is a command that should
>> be looked up in PATH". This is congruent with alias definitions, where the
>> leading ! means to run the following value as a command directly instead of
>> as a git subcommand.
>>
>> This also is unambiguous since server hostnames will never begin with a !
>> character.
>
> IMHO this is a good path forward. There's a thread from a few months ago
> which talks about this idea:
>
> https://lore.kernel.org/git/YCvotU6KVruFuf9%2F@coredump.intra.peff.net/
>
> There's some back and forth, and I'm not sure if I convinced Junio in
> the end. But certainly a patch would be a good way to restart the
> conversation. :)
The argument is not just about configuration but applies equally to
its command line argument "--smtp-server=<what>", right? I think it
makes sense in both of these places. I further wonder if we should
allow not just a single token, but supplying an initial few arguments,
too, e.g.
git send-email --smtp-server="/usr/bin/env msmtp"
git send-email --smtp-server="!my-msa --emulate-sendmail"
Thanks.
next prev parent reply other threads:[~2021-05-11 22:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 18:07 Syntax for specifying a command in git config Gregory Anders
2021-05-11 18:17 ` Jeff King
2021-05-11 22:56 ` Junio C Hamano [this message]
2021-05-12 0:32 ` Jeff King
2021-05-12 3:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo8dgj2vk.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=greg@gpanders.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).