From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.0 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id CB7EC1F670 for ; Wed, 13 Oct 2021 04:48:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230126AbhJMEuL (ORCPT ); Wed, 13 Oct 2021 00:50:11 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:62241 "EHLO pb-smtp21.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229628AbhJMEuK (ORCPT ); Wed, 13 Oct 2021 00:50:10 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id E808A167CBE; Wed, 13 Oct 2021 00:48:07 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=sasl; bh=gBD7IcX5oqSkYeCqap38eGcezKrqGIYQSFPkZLTC1Fs=; b=u0zJ acah1L5uvD3Zn3zzZCxeTwd9bR5rf5jOtSJSdmwACLmXWjk+E3/SAhQzQisD/EXL zOHYmZyOfSE4UmEU/bVc//KIC719dM0ZAEE39O6RU+o/52pH/VyR93LERBO3ldi7 w0p7HDNo2EKToIkKDQGpQLuJy10bQrMAZ5PvYXY= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id E0FB4167CBC; Wed, 13 Oct 2021 00:48:07 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 4A2CE167CBB; Wed, 13 Oct 2021 00:48:05 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Sergey Organov Cc: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , Eric Sunshine , Git List , Thomas Rast , Denton Liu Subject: Re: [PATCH RFC v1] stash: implement '--staged' option for 'push' and 'save' References: <875yugcs3l.fsf@osv.gnss.ru> <87lf2zz59w.fsf@osv.gnss.ru> <87fst7z0oa.fsf@osv.gnss.ru> <87y26yk35r.fsf@evledraar.gmail.com> <87k0ii446g.fsf@osv.gnss.ru> <87lf2yqevj.fsf@osv.gnss.ru> Date: Tue, 12 Oct 2021 21:48:04 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: C10D7620-2BE0-11EC-87FC-98D80D944F46-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Sergey Organov writes: > I didn't ask you what --staged is suitable for, sorry. I asked how do > you solve the problem of saving an *entirely unrelated* subset of > changes for future use? Ah, OK. I do not think I would "git add" unrelated pieces in the first place, so "add -p && stash --staged" as a way to stash away such a change would be quite foreign concept in my workflow. IOW, I'd concentrate on finishing the step I am working on, leaving unrelated changes in the working tree, and when I came to a good stopping point, I'd do the "stash -k && test && commit" dance, followed by "stash pop". At that point,the working tree would have only unrelated changes that I can stash away with "stash save". So I guess perhaps your "no such problem for me" is the closest? Thanks.