From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_PASS,SPF_PASS,URIBL_CSS,URIBL_CSS_A shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id AAD721F953 for ; Wed, 3 Nov 2021 17:42:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229885AbhKCRoy (ORCPT ); Wed, 3 Nov 2021 13:44:54 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:57752 "EHLO pb-smtp1.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229558AbhKCRox (ORCPT ); Wed, 3 Nov 2021 13:44:53 -0400 Received: from pb-smtp1.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 9D25CE385A; Wed, 3 Nov 2021 13:42:16 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=drbIUO7qKbowIEKCoJkaFxSLZwcWD3hjQMOezk i2A6s=; b=fc4LQAZTjAtqECRUP25YnDiO6P5JX42WcDmMeHI/l/WDu6amCHLHyQ zjDtV75n7axte+G1EtSMWBS4l3v6eXE2m/zo8DUK+VSRP+gAbjTE21ni2aypMFOq ZWClCBLrfEuKIWDo1WF8wG4FMdP57cAiDd2O9Cm0oFulYbr6JYIfI= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 94B81E3859; Wed, 3 Nov 2021 13:42:16 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [104.133.2.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id 0A686E3858; Wed, 3 Nov 2021 13:42:15 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: Jeff King Cc: =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , git@vger.kernel.org, Johannes Schindelin , Alejandro Sanchez Subject: Re: [PATCH 2/2] prompt.c: add and use a GIT_TEST_TERMINAL_PROMPT=true References: <20190524062724.GC25694@sigill.intra.peff.net> Date: Wed, 03 Nov 2021 10:42:14 -0700 In-Reply-To: (Jeff King's message of "Wed, 3 Nov 2021 07:57:22 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 628689F4-3CCD-11EC-BE44-62A2C8D8090B-77302942!pb-smtp1.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Jeff King writes: > Basically, I think I just disagree with this paragraph entirely. Moving > to stdin in the commits you referenced was done to help testing, but I > also think it's just a more flexible direction overall. It is OK, and it is more convenient for writing test scripts, to take interactive input from the standard input stream, if the command does not use the standard input for other purposes. "git am -i