From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: Phillip Wood <phillip.wood@dunelm.org.uk>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: BUG: fast-import, ftruncate, and file mode
Date: Wed, 23 Feb 2022 15:18:17 -0800 [thread overview]
Message-ID: <xmqqo82xp3ye.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BF_ygATPVGfSR24URm5ZTHBJwJd0miMtgMgNWfw_o33Nw@mail.gmail.com> (Elijah Newren's message of "Wed, 23 Feb 2022 07:33:29 -0800")
Elijah Newren <newren@gmail.com> writes:
>> Am I missing something or is this really a file system bug? Surely if we
>> have opened a file for writing the file permissions when we call
>> ftruncate() should be irrelevant?
>> ...
> Oh, indeed, looks like I can't read late at night. Sorry for the noise.
Was wondering the same thing.
We open for writing, write one object at a time and when we realize
we do not have to, we rewind that stream we are writing into using
ftruncate(). It would be a serious problem if we cannot do that.
prev parent reply other threads:[~2022-02-23 23:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 7:47 BUG: fast-import, ftruncate, and file mode Elijah Newren
2022-02-23 13:59 ` Phillip Wood
2022-02-23 15:33 ` Elijah Newren
2022-02-23 23:18 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo82xp3ye.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).