From: Junio C Hamano <gitster@pobox.com>
To: "Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "Eric Sunshine" <sunshine@sunshineco.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Jeff Hostetler" <git@jeffhostetler.com>,
"René Scharfe" <l.s.r@web.de>,
"Jeff Hostetler" <jeffhost@microsoft.com>
Subject: Re: [PATCH v2] config.mak.dev: disable suggest braces error on old clang versions
Date: Mon, 10 Oct 2022 11:13:34 -0700 [thread overview]
Message-ID: <xmqqo7uj35td.fsf@gitster.g> (raw)
In-Reply-To: <pull.1375.v2.git.1665416340806.gitgitgadget@gmail.com> (Jeff Hostetler via GitGitGadget's message of "Mon, 10 Oct 2022 15:39:00 +0000")
"Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Here is version 2. This version adds the "-Wno-missing-braces" compiler
> flag when we are using an old version of clang -- rather than updating
> the source files to use the "{{0}}" syntax that was expected by older
> versions of clang.
>
> I've expanded the scope to include fixes for Apple's clang 11 and below
> and non-Apple clang 8 and below.
>
> diff --git a/config.mak.dev b/config.mak.dev
> index 4fa19d361b7..981304727c5 100644
> --- a/config.mak.dev
> +++ b/config.mak.dev
> @@ -69,6 +69,31 @@ DEVELOPER_CFLAGS += -Wno-missing-braces
> endif
> endif
>
> +# Old versions of clang complain about initializaing a
> +# struct-within-a-struct using just "{0}" rather than "{{0}}". This
> +# error is considered a false-positive and not worth fixing, because
> +# new clang versions do not, so just disable it.
> +#
> +# The "bug" was fixed in upstream clang 9.
> +#
> +# Complicating this is that versions of clang released by Apple have
> +# their own version numbers (associated with the corresponding version
> +# of XCode) unrelated to the official clang version numbers.
> +#
> +# The bug was fixed in Apple clang 12.
> +#
> +ifneq ($(filter clang1,$(COMPILER_FEATURES)),) # if we are using clang
> +ifeq ($(uname_S),Darwin) # if we are on darwin
> +ifeq ($(filter clang12,$(COMPILER_FEATURES)),) # if version < 12
> +DEVELOPER_CFLAGS += -Wno-missing-braces
> +endif
> +else # not darwin
> +ifeq ($(filter clang9,$(COMPILER_FEATURES)),) # if version < 9
> +DEVELOPER_CFLAGS += -Wno-missing-braces
> +endif
> +endif
> +endif
Looks very straight-forward, albeit a tad verbose, and simple to
follow. I think this is equivalent to René's original one-liner.
Will queue. Thanks.
next prev parent reply other threads:[~2022-10-10 18:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 19:43 [PATCH 0/2] Fix syntax errors under clang 11.0.0 on MacOS Jeff Hostetler via GitGitGadget
2022-10-06 19:43 ` [PATCH 1/2] builtin/merge-file: fix compiler error on MacOS with clang 11.0.0 Jeff Hostetler via GitGitGadget
2022-10-06 21:09 ` René Scharfe
2022-10-06 22:30 ` Eric Sunshine
2022-10-06 22:51 ` Junio C Hamano
2022-10-06 19:43 ` [PATCH 2/2] builtin/unpack-objects.c: " Jeff Hostetler via GitGitGadget
2022-10-06 20:38 ` [PATCH 0/2] Fix syntax errors under clang 11.0.0 on MacOS Junio C Hamano
2022-10-06 20:58 ` Eric Sunshine
2022-10-07 11:02 ` Ævar Arnfjörð Bjarmason
2022-10-07 15:19 ` Jeff Hostetler
2022-10-07 17:49 ` Junio C Hamano
2022-10-07 20:28 ` René Scharfe
2022-10-07 20:56 ` Jeff Hostetler
2022-10-07 21:33 ` Junio C Hamano
2022-10-08 3:46 ` Eric Sunshine
2022-10-08 6:52 ` René Scharfe
2022-10-09 5:19 ` Junio C Hamano
2022-10-07 21:30 ` Junio C Hamano
2022-10-10 15:39 ` [PATCH v2] config.mak.dev: disable suggest braces error on old clang versions Jeff Hostetler via GitGitGadget
2022-10-10 18:13 ` Junio C Hamano [this message]
2022-10-11 0:15 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo7uj35td.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jeffhost@microsoft.com \
--cc=l.s.r@web.de \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).