From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 13DF31F403 for ; Mon, 17 Oct 2022 15:19:11 +0000 (UTC) Authentication-Results: dcvr.yhbt.net; dkim=pass (1024-bit key; unprotected) header.d=pobox.com header.i=@pobox.com header.b="euMdYoC3"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231345AbiJQPTG (ORCPT ); Mon, 17 Oct 2022 11:19:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231506AbiJQPTC (ORCPT ); Mon, 17 Oct 2022 11:19:02 -0400 Received: from pb-smtp21.pobox.com (pb-smtp21.pobox.com [173.228.157.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 992BA52457 for ; Mon, 17 Oct 2022 08:19:01 -0700 (PDT) Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id AD5E71CB935; Mon, 17 Oct 2022 11:19:00 -0400 (EDT) (envelope-from junio@pobox.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=Ef/XDysvHNsDtZKg7D/mgcP28Fkos2UGq0A57/ +GOHk=; b=euMdYoC3Ee7Iex8yp+2RhBfqv+x8pEWqcVdRt0VXHRe3a57UbnzA7G wn4/nAwr/qeapDWOaWraJyymFUcAb+62TrYxeXjjIfqjYsX8Y+FcytZPGoYeDb8d Wd568ryqZcucJrqLUxQHKgAzs1NgZC+QPIok6mCxD1A0EXyNnZ4Sk= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id A58381CB934; Mon, 17 Oct 2022 11:19:00 -0400 (EDT) (envelope-from junio@pobox.com) Received: from pobox.com (unknown [34.83.5.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id A32A11CB930; Mon, 17 Oct 2022 11:18:57 -0400 (EDT) (envelope-from junio@pobox.com) From: Junio C Hamano To: "Jerry Zhang via GitGitGadget" Cc: git@vger.kernel.org, Jerry Zhang Subject: Re: [PATCH v3 7/7] documentation: format-patch: clarify requirements for patch-ids to match References: <69440797f302729d59f19c0994916e193c9dbf58.1665737804.git.gitgitgadget@gmail.com> Date: Mon, 17 Oct 2022 08:18:56 -0700 In-Reply-To: <69440797f302729d59f19c0994916e193c9dbf58.1665737804.git.gitgitgadget@gmail.com> (Jerry Zhang via GitGitGadget's message of "Fri, 14 Oct 2022 08:56:44 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 053F584C-4E2F-11ED-8322-B31D44D1D7AA-77302942!pb-smtp21.pobox.com Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org "Jerry Zhang via GitGitGadget" writes: > The 'base commit' is shown as "base-commit: " followed by the 40-hex of > the commit object name. A 'prerequisite patch' is shown as > "prerequisite-patch-id: " followed by the 40-hex 'patch id', which can > -be obtained by passing the patch through the `git patch-id --stable` > -command. > +be obtained by passing the patch (generated with -U3 --full-index) through > +the `git patch-id --stable` command. This is not incorrect per-se, but I wonder how much it would help or mislead people in practice. I understand that the update means well to help those who complain "'patch-id' produces wrong result when I feed the output of 'git diff -U1'" by making them suspect that their -U1 may be the culprit. But the new description does not cover everything that can affect the resulting patch ID (the choice of --diff-algorithm affects how common lines are matched up between the preimage and the postimage, for example). So, I dunno.