From: Junio C Hamano <gitster@pobox.com>
To: "M Hickford via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
"Johannes Schindelin [ ]" <Johannes.Schindelin@gmx.de>,
"Johannes Sixt [ ]" <j6t@kdbg.org>,
"Harshil Jani [ ]" <harshiljani2002@gmail.com>,
"Jakub Bereżański" <kuba@berezanscy.pl>,
"Karsten Blees" <blees@dcon.de>,
"Erik Faye-Lund" <kusmabite@gmail.com>,
"Javier Roucher Iglesias"
<Javier.Roucher-Iglesias@ensimag.imag.fr>,
"M Hickford" <mirth.hickford@gmail.com>
Subject: Re: [PATCH v2] credential/wincred: store password_expiry_utc
Date: Thu, 30 Mar 2023 12:19:35 -0700 [thread overview]
Message-ID: <xmqqo7oahws8.fsf@gitster.g> (raw)
In-Reply-To: <pull.1477.v2.git.git.1680200278780.gitgitgadget@gmail.com> (M. Hickford via GitGitGadget's message of "Thu, 30 Mar 2023 18:17:58 +0000")
"M Hickford via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: M Hickford <mirth.hickford@gmail.com>
>
> This attribute is important when storing OAuth credentials which may
> expire after as little as one hour. See
> https://github.com/git/git/commit/d208bfdfef97a1e8fb746763b5057e0ad91e283b
Readers do not have to visit GitHub at all, and proposed log message
shouldn't force them to. Refer to an existing commit in this
project like so instead:
... as one hour. d208bfdf (credential: new attribute
password_expiry_utc, 2023-02-18) added support for this
attribute in general so that individual credential backend like
wincred can use it.
> Help wanted from a Windows user to test. I tried testing on Linux with
> Wine after cross-compiling [1] but Wine has incomplete support for
> wincred.h [2]. To test:
I cannot be one to help testing but ...
> @@ -292,7 +313,7 @@ int main(int argc, char *argv[])
> "usage: git credential-wincred <get|store|erase>\n";
>
> if (!argv[1])
> - die(usage);
> + die("%s", usage);
... this is a nice one. Logically it may belong to a separate
topic, but it is small and obvious enough that it is OK to do as a
"while at it" clean-up.
next prev parent reply other threads:[~2023-03-30 19:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 7:39 [PATCH] credential/wincred: store password_expiry_utc M Hickford via GitGitGadget
2023-03-28 12:14 ` Johannes Schindelin
2023-03-30 5:50 ` M Hickford
2023-05-01 22:25 ` Junio C Hamano
2023-05-02 9:38 ` M Hickford
2023-05-02 17:43 ` Johannes Sixt
2023-05-02 18:16 ` Felipe Contreras
2023-03-30 18:17 ` [PATCH v2] " M Hickford via GitGitGadget
2023-03-30 19:19 ` Junio C Hamano [this message]
2023-04-03 7:00 ` M Hickford
2023-04-03 7:47 ` [PATCH v3] " M Hickford via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqo7oahws8.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Javier.Roucher-Iglesias@ensimag.imag.fr \
--cc=Johannes.Schindelin@gmx.de \
--cc=blees@dcon.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=harshiljani2002@gmail.com \
--cc=j6t@kdbg.org \
--cc=kuba@berezanscy.pl \
--cc=kusmabite@gmail.com \
--cc=mirth.hickford@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).