From: Junio C Hamano <gitster@pobox.com>
To: Lars Schneider <larsxschneider@gmail.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder@ira.uka.de>
Subject: Re: [PATCH] t9824: fix wrong reference value
Date: Fri, 29 Apr 2016 10:34:13 -0700 [thread overview]
Message-ID: <xmqqmvocz5d6.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <0102015462bcd1c3-4196e36b-515b-447f-beca-649922456098-000000@eu-west-1.amazonses.com> (Lars Schneider's message of "Fri, 29 Apr 2016 15:57:02 +0000")
Lars Schneider <larsxschneider@gmail.com> writes:
> 0492eb4 fixed a broken &&-chain in this test which broke the test as it
> checked for a wrong size. The expected size of the file under test is
> 39 bytes. The test checked that the size is 13 bytes. Fix the reference
> value to make the test pass, again.
>
> Signed-off-by: Lars Schneider <larsxschneider@gmail.com>
> ---
That breaking "fix" seems to have been acked by you.
It was sort of clear that SZEDER didn't actually ran the test from
the patch, saying "As far as I can tell after eyeballing the test
script,", but you obviously didn't actually have a chance to test it
until now.
Thanks for fixing it before it hits 'master'; this time I think it
is safe to assume that this was actually tested ;-)
> t/t9824-git-p4-git-lfs.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t9824-git-p4-git-lfs.sh b/t/t9824-git-p4-git-lfs.sh
> index 64f8d18..3fc6790 100755
> --- a/t/t9824-git-p4-git-lfs.sh
> +++ b/t/t9824-git-p4-git-lfs.sh
> @@ -265,7 +265,7 @@ test_expect_success 'Add big files to repo and store files in LFS based on compr
> # We only import HEAD here ("@all" is missing!)
> git p4 clone --destination="$git" //depot &&
>
> - test_file_in_lfs file6.bin 13 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" &&
> + test_file_in_lfs file6.bin 39 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" &&
> test_file_count_in_dir ".git/lfs/objects" 1 &&
>
> cat >expect <<-\EOF &&
>
> --
> https://github.com/git/git/pull/235
next prev parent reply other threads:[~2016-04-29 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 15:57 [PATCH] t9824: fix wrong reference value Lars Schneider
2016-04-29 17:34 ` Junio C Hamano [this message]
2016-04-29 20:29 ` Lars Schneider
2016-04-29 20:40 ` Luke Diamand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmvocz5d6.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
--cc=szeder@ira.uka.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).