git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Torsten Bögershausen" <tboegi@web.de>
Cc: Beat Bolli <dev+git@drbeat.li>, git@vger.kernel.org
Subject: Re: [PATCH v4 1/3] update-unicode.sh: automatically download newer definition files
Date: Mon, 05 Dec 2016 12:31:46 -0800	[thread overview]
Message-ID: <xmqqmvga3yod.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20161204075800.GA2415@tb-raspi> ("Torsten Bögershausen"'s message of "Sun, 4 Dec 2016 07:58:00 +0000")

Torsten Bögershausen <tboegi@web.de> writes:

> On Sat, Dec 03, 2016 at 10:00:47PM +0100, Beat Bolli wrote:
>> Checking just for the unicode data files' existence is not sufficient;
>> we should also download them if a newer version exists on the Unicode
>> consortium's servers. Option -N of wget does this nicely for us.
>> 
>> Reviewed-by: Torsten Boegershausen <tboegi@web.de>
>
> Minor remark (Not sure if this motivates v5, may be Junio can fix it locally?)
> s/oe/ö/
>
> Beside this: Thanks again (and I learned about the -N option of wget)

Will fix up while queuing (only 1/3 needs it, 2/3 has it right).

Also, I'll do s/update-unicode.sh/update_unicode.sh/ on the title
and the message to match the reality.  At some point we might want
to fix the reality to match people's expectations, though.

Thanks.

  reply	other threads:[~2016-12-05 20:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02 21:26 [PATCH 1/2] update-unicode.sh: automatically download newer definition files Beat Bolli
2016-12-02 21:26 ` [PATCH 2/2] unicode: update the tables to Unicode 9.0 Beat Bolli
2016-12-03 10:35 ` [PATCH 3/3] unicode_width.h: fix the double_width[] table Beat Bolli
2016-12-03 10:53 ` [PATCH v2 1/3] update-unicode.sh: automatically download newer definition files Beat Bolli
2016-12-03 10:53   ` [PATCH v2 2/3] unicode_width.h: update the tables to Unicode 9.0 Beat Bolli
2016-12-03 10:53   ` [PATCH v2 3/3] unicode_width.h: fix the double_width[] table Beat Bolli
2016-12-03 13:19     ` [PATCH v3 1/3] update-unicode.sh: automatically download newer definition files Beat Bolli
2016-12-03 13:19       ` [PATCH v3 2/3] update-unicode.sh: strip the plane offsets from the double_width[] table Beat Bolli
2016-12-03 13:19       ` [PATCH v3 3/3] unicode_width.h: update the tables to Unicode 9.0 Beat Bolli
2016-12-03 16:40       ` [PATCH v3 1/3] update-unicode.sh: automatically download newer definition files Torsten =?unknown-8bit?Q?B=C3=B6gershausen?=
2016-12-03 16:41         ` Beat Bolli
2016-12-03 21:00           ` [PATCH v4 " Beat Bolli
2016-12-03 21:00             ` [PATCH v4 2/3] update-unicode.sh: strip the plane offsets from the double_width[] table Beat Bolli
2016-12-03 21:00             ` [PATCH v4 3/3] unicode_width.h: update the tables to Unicode 9.0 Beat Bolli
2016-12-04  7:58             ` [PATCH v4 1/3] update-unicode.sh: automatically download newer definition files Torsten Bögershausen
2016-12-05 20:31               ` Junio C Hamano [this message]
2016-12-07  0:17                 ` Beat Bolli
2016-12-07  1:00                   ` jbh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmvga3yod.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=dev+git@drbeat.li \
    --cc=git@vger.kernel.org \
    --cc=tboegi@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).