From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: git@vger.kernel.org, "Nguyen Thai Ngoc Duy" <pclouds@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Ramsay Jones" <ramsay@ramsayjones.plus.com>,
"Jeff King" <peff@peff.net>,
"Christian Couder" <chriscool@tuxfamily.org>
Subject: Re: [PATCH v4 00/22] Add configuration options for split-index
Date: Wed, 01 Mar 2017 13:29:52 -0800 [thread overview]
Message-ID: <xmqqmvd4fzxr.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20170227180019.18666-1-chriscool@tuxfamily.org> (Christian Couder's message of "Mon, 27 Feb 2017 18:59:57 +0100")
Christian Couder <christian.couder@gmail.com> writes:
> Highlevel view of the patches in the series
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Except for patch 1/22 and 1/22, there are 3 big steps, one for each
> new configuration variable introduced.
>
> There only small differences between this patch series and the v3
> patch series sent a few months ago.
>
> - Patch 1/22 marks a message for translation. It is not new and
> can be applied separately.
>
> - Patch 2/22 improves the existing indentation style of t1700 by
> using different here document style. It is a new preparatory
> patch suggested by Junio.
OK. I read interdiff against the previous round carefully, and
skimmed all patches less carefully.
I may have comments on individual patches later, but this round
looked mostly sensible.
Thanks for following it through.
prev parent reply other threads:[~2017-03-01 21:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 17:59 [PATCH v4 00/22] Add configuration options for split-index Christian Couder
2017-02-27 17:59 ` [PATCH v4 01/22] config: mark an error message up for translation Christian Couder
2017-02-27 17:59 ` [PATCH v4 02/22] t1700: change here document style Christian Couder
2017-02-27 18:00 ` [PATCH v4 03/22] config: add git_config_get_split_index() Christian Couder
2017-02-27 18:00 ` [PATCH v4 04/22] split-index: add {add,remove}_split_index() functions Christian Couder
2017-02-27 18:00 ` [PATCH v4 05/22] read-cache: add and then use tweak_split_index() Christian Couder
2017-02-27 18:00 ` [PATCH v4 06/22] update-index: warn in case of split-index incoherency Christian Couder
2017-02-27 18:00 ` [PATCH v4 07/22] t1700: add tests for core.splitIndex Christian Couder
2017-02-27 18:00 ` [PATCH v4 08/22] Documentation/config: add information " Christian Couder
2017-02-27 18:00 ` [PATCH v4 09/22] Documentation/git-update-index: talk about core.splitIndex config var Christian Couder
2017-02-27 18:00 ` [PATCH v4 10/22] config: add git_config_get_max_percent_split_change() Christian Couder
2017-02-27 18:00 ` [PATCH v4 11/22] read-cache: regenerate shared index if necessary Christian Couder
2017-02-27 18:00 ` [PATCH v4 12/22] t1700: add tests for splitIndex.maxPercentChange Christian Couder
2017-02-27 18:00 ` [PATCH v4 13/22] Documentation/config: add splitIndex.maxPercentChange Christian Couder
2017-02-27 18:00 ` [PATCH v4 14/22] sha1_file: make check_and_freshen_file() non static Christian Couder
2017-02-27 18:00 ` [PATCH v4 15/22] read-cache: touch shared index files when used Christian Couder
2017-03-01 21:34 ` Junio C Hamano
2017-02-27 18:00 ` [PATCH v4 16/22] config: add git_config_get_expiry() from gc.c Christian Couder
2017-02-27 18:00 ` [PATCH v4 17/22] read-cache: unlink old sharedindex files Christian Couder
2017-03-01 21:39 ` Junio C Hamano
2017-02-27 18:00 ` [PATCH v4 18/22] t1700: test shared index file expiration Christian Couder
2017-02-27 18:00 ` [PATCH v4 19/22] read-cache: refactor read_index_from() Christian Couder
2017-02-27 18:00 ` [PATCH v4 20/22] read-cache: use freshen_shared_index() in read_index_from() Christian Couder
2017-02-27 18:00 ` [PATCH v4 21/22] Documentation/config: add splitIndex.sharedIndexExpire Christian Couder
2017-02-27 18:00 ` [PATCH v4 22/22] Documentation/git-update-index: explain splitIndex.* Christian Couder
2017-03-01 21:29 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmvd4fzxr.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).