From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Michael J Gruber <git@grubix.eu>,
Lars Schneider <larsxschneider@gmail.com>
Subject: Re: [PATCH] tests: fix tests broken under GETTEXT_POISON=YesPlease
Date: Tue, 25 Apr 2017 18:58:32 -0700 [thread overview]
Message-ID: <xmqqmvb4szef.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CACBZZX494g8CKoN0V1N4xRuDsErPtJcMjaZcLFAqJgDQ+Mz+yA@mail.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Tue, 25 Apr 2017 10:56:43 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> Indeed, I've tried to be careful not to introduce bugs like that, but
> in this skipped case the tests look completely stand-alone to me.
Yes, the ones I commented on in the upthread looked like their side
effect were not felt in the later tests.
> In any case, I like my other patch to just remove this whole thing better.
Hmph, did I miss a patch message?
next prev parent reply other threads:[~2017-04-26 1:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 21:58 [BUG] test suite broken with GETTEXT_POISON=YesPlease Ævar Arnfjörð Bjarmason
2017-04-21 14:47 ` Michael J Gruber
2017-04-21 17:28 ` Ævar Arnfjörð Bjarmason
2017-04-24 1:18 ` Junio C Hamano
[not found] ` <20170424110434.27689-1-avarab@gmail.com>
2017-04-26 9:17 ` [PATCH] tests: remove the GETTEXT_POISON compile-time option to test i18n marking Michael J Gruber
2017-04-26 14:27 ` Ævar Arnfjörð Bjarmason
2017-04-21 14:54 ` [BUG] test suite broken with GETTEXT_POISON=YesPlease Lars Schneider
2017-04-21 18:05 ` Ævar Arnfjörð Bjarmason
2017-04-21 18:57 ` [PATCH] tests: fix tests broken under GETTEXT_POISON=YesPlease Ævar Arnfjörð Bjarmason
2017-04-24 1:15 ` Junio C Hamano
2017-04-24 8:18 ` Ævar Arnfjörð Bjarmason
2017-04-25 4:11 ` Junio C Hamano
2017-04-25 8:56 ` Ævar Arnfjörð Bjarmason
2017-04-26 1:58 ` Junio C Hamano [this message]
2017-04-26 7:56 ` Ævar Arnfjörð Bjarmason
2017-04-24 13:22 ` [BUG] test suite broken with GETTEXT_POISON=YesPlease Duy Nguyen
2017-04-24 20:37 ` Jeff King
2017-04-25 8:51 ` Lars Schneider
2017-04-25 10:01 ` Jeff King
2017-04-28 8:42 ` Lars Schneider
2017-04-28 8:44 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmvb4szef.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@grubix.eu \
--cc=git@vger.kernel.org \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).